From: Lars-Peter Clausen <lars@metafoo.de>
To: George McCollister <george.mccollister@gmail.com>
Cc: Daniel Baluta <daniel.baluta@intel.com>,
"open list:IIO SUBSYSTEM AND..." <devel@driverdev.osuosl.org>,
list@osuosl.org, Reyad Attiyat <reyad.attiyat@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
open list <linux-kernel@vger.kernel.org>,
Harald Geyer <harald@ccbib.org>,
Sebastian Reichel <sre@debian.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
open@osuosl.org, ABI/API <linux-api@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 1/2] iio: Add support for waveform output
Date: Mon, 01 Dec 2014 20:56:38 +0100 [thread overview]
Message-ID: <547CC7F6.2050900@metafoo.de> (raw)
In-Reply-To: <CAFSKS=PdS7cLuHEKawKsQ-tePRg-t9Q8wDA5e51f1ejW91=N4A@mail.gmail.com>
On 12/01/2014 03:57 PM, George McCollister wrote:
> On Wed, Nov 26, 2014 at 4:06 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> On 11/26/2014 10:45 PM, George McCollister wrote:
>>>
>>> Output can be held high or low for a specified period of time.
>>> Support for waveform capture could be added in the future.
>>>
>>
>> That's a PWM device?
>
> The device I'm adding only generates a single pulse per write, but my
> intention was to leave the door open for other types of devices.
>
Can you try to elaborate more on how exactly this interface is supposed to
be used, what kind of the devices it is used for, the use case of the device
and so on. This patch is adding userspace ABI which we have to maintain
forever so we should try to give this proper review, which is not easy
without knowing what it actually is.
- Lars
prev parent reply other threads:[~2014-12-01 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 21:45 [PATCH 1/2] iio: Add support for waveform output George McCollister
2014-11-26 22:06 ` Lars-Peter Clausen
[not found] ` <CAFSKS=PdS7cLuHEKawKsQ-tePRg-t9Q8wDA5e51f1ejW91=N4A@mail.gmail.com>
2014-12-01 19:56 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CC7F6.2050900@metafoo.de \
--to=lars@metafoo.de \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=george.mccollister@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=harald@ccbib.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list@osuosl.org \
--cc=open@osuosl.org \
--cc=pmeerw@pmeerw.net \
--cc=reyad.attiyat@gmail.com \
--cc=sre@debian.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).