From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 1/2] iio: Add support for waveform output Date: Mon, 01 Dec 2014 20:56:38 +0100 Message-ID: <547CC7F6.2050900@metafoo.de> References: <1417038344-3801-1-git-send-email-george.mccollister@gmail.com> <54764F01.20005@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: George McCollister Cc: Daniel Baluta , "open list:IIO SUBSYSTEM AND..." , list@osuosl.org, Reyad Attiyat , Greg Kroah-Hartman , Hartmut Knaack , open list , Harald Geyer , Sebastian Reichel , Peter Meerwald , Srinivas Pandruvada , open@osuosl.org, ABI/API , Jonathan Cameron List-Id: linux-api@vger.kernel.org On 12/01/2014 03:57 PM, George McCollister wrote: > On Wed, Nov 26, 2014 at 4:06 PM, Lars-Peter Clausen wrote: >> On 11/26/2014 10:45 PM, George McCollister wrote: >>> >>> Output can be held high or low for a specified period of time. >>> Support for waveform capture could be added in the future. >>> >> >> That's a PWM device? > > The device I'm adding only generates a single pulse per write, but my > intention was to leave the door open for other types of devices. > Can you try to elaborate more on how exactly this interface is supposed to be used, what kind of the devices it is used for, the use case of the device and so on. This patch is adding userspace ABI which we have to maintain forever so we should try to give this proper review, which is not easy without knowing what it actually is. - Lars