From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: Re: [PATCH v3 05/20] selftests/ftrace: add install target to enable test install Date: Sun, 04 Jan 2015 14:29:34 +0900 Message-ID: <54A8CFBE.2010209@hitachi.com> References: <20150102104526.29df5641@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150102104526.29df5641@gandalf.local.home> Sender: linux-kbuild-owner@vger.kernel.org To: Steven Rostedt Cc: Shuah Khan , mmarek@suse.cz, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mingo@redhat.com, davem@davemloft.net, keescook@chromium.org, tranmanphong@gmail.com, mpe@ellerman.id.au, cov@codeaurora.org, dh.herrmann@gmail.com, hughd@google.com, bobby.prani@gmail.com, serge.hallyn@ubuntu.com, ebiederm@xmission.com, tim.bird@sonymobile.com, josh@joshtriplett.org, koct9i@gmail.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, "yrl.pp-manager.tt@hitachi.com" List-Id: linux-api@vger.kernel.org (2015/01/03 0:45), Steven Rostedt wrote: > On Wed, 24 Dec 2014 09:27:41 -0700 > Shuah Khan wrote: > >> Add a new make target to enable installing test. This target >> installs test in the kselftest install location and add to the >> kselftest script to run the test. Install target can be run >> only from top level kernel source directory. >> >> Signed-off-by: Shuah Khan >> --- >> tools/testing/selftests/ftrace/Makefile | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile >> index 76cc9f1..7c7cf42 100644 >> --- a/tools/testing/selftests/ftrace/Makefile >> +++ b/tools/testing/selftests/ftrace/Makefile >> @@ -1,7 +1,16 @@ >> +TEST_STR = /bin/sh ./ftracetest || echo ftrace selftests: [FAIL] > > Is it ok that this removes the quotes around the echo string? I don't > see anything wrong about it, but I don't know if there's a shell out > there that will fail due to it. Agreed, if possible, we'd better add quotes around the echo string as you did in 2/20 in this series. Anyway, you can also add my ack to this patch. Acked-by: Masami Hiramatsu Thank you! > > Other than than, > > Acked-by: Steven Rostedt > > -- Steve > > >> + >> all: >> >> +install: >> +ifdef INSTALL_KSFT_PATH >> + install ./ftracetest $(INSTALL_KSFT_PATH) >> + @cp -r test.d $(INSTALL_KSFT_PATH) >> + echo "$(TEST_STR)" >> $(KSELFTEST) >> +endif >> + >> run_tests: >> - @/bin/sh ./ftracetest || echo "ftrace selftests: [FAIL]" >> + @$(TEST_STR) >> >> clean: >> rm -rf logs/* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com