From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: Edited seccomp.2 man page for review [v2] Date: Wed, 07 Jan 2015 13:41:39 +0100 Message-ID: <54AD2983.2060108@gmail.com> References: <54A29722.1010901@gmail.com> <54A300D0.7090802@gmail.com> <54AD1E37.8020509@gmail.com> <54AD2549.9040107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54AD2549.9040107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Borkmann Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Kees Cook , Linux API , "linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , lkml , Will Drewry , ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org List-Id: linux-api@vger.kernel.org On 01/07/2015 01:23 PM, Daniel Borkmann wrote: > On 01/07/2015 12:53 PM, Michael Kerrisk (man-pages) wrote: > ... >> Still hoping to hear from Will Drewy regarding this FIXME in the >> page source: >> >> .\" FIXME What is the significance of the line >> .\" ftest->code = BPF_LDX | BPF_W | BPF_ABS; >> .\" in kernel/seccomp.c::seccomp_check_filter()? > > This came in from our rework via commit bd4cf0ed331a ("net: filter: > rework/optimize internal BPF interpreter's instruction set"), and > is kernel-internal only, and unused in classic BPF. It translates > into A = *(u32 *) (ctx + K) and will basically load an offset from > the populated seccomp_data (= ctx) to A. For the man-page itself > it has therefore no relevance, hope that clarifies it. Thanks, Daniel. Okay -- that was the last hurdle. The page should go out with the next man-pages release. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/