From: David Vrabel <david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Mikko Rapeli <mikko.rapeli-X3B1VOXEql0@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: David Vrabel
<david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
Boris Ostrovsky
<boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [Xen-devel] [PATCH 25/45] gntalloc.h: include stdint.h in userspace
Date: Wed, 18 Feb 2015 11:53:22 +0000 [thread overview]
Message-ID: <54E47D32.9040208@citrix.com> (raw)
In-Reply-To: <1424127948-22484-26-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
On 16/02/15 23:05, Mikko Rapeli wrote:
> Fixes compilation error:
>
> xen/gntalloc.h:22:2: error: unknown type name ‘uint16_t’
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli-X3B1VOXEql0@public.gmane.org>
> ---
> include/uapi/xen/gntalloc.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/xen/gntalloc.h b/include/uapi/xen/gntalloc.h
> index 76bd580..184df7e 100644
> --- a/include/uapi/xen/gntalloc.h
> +++ b/include/uapi/xen/gntalloc.h
> @@ -11,6 +11,12 @@
> #ifndef __LINUX_PUBLIC_GNTALLOC_H__
> #define __LINUX_PUBLIC_GNTALLOC_H__
>
> +#ifdef __KERNEL__
> +#include <linux/types.h>
> +#else
> +#include <stdint.h>
> +#endif
I think it would be preferrable to #include <linux/types.h> only and
switch to using the __u32 etc. types (as others have suggested).
David
next prev parent reply other threads:[~2015-02-18 11:53 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi>
2015-02-16 23:05 ` [PATCH 05/45] drm.h: include stdlib.h in userspace Mikko Rapeli
[not found] ` <1424127948-22484-6-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-23 10:26 ` Emil Velikov
[not found] ` <54EB0072.8020909-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-23 10:35 ` Mikko Rapeli
[not found] ` <20150223103548.GT12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-20 20:25 ` Emil Velikov
[not found] ` <CACvgo50PA5nb27EcxQqXY49C5hmvDDxi3WOqB=op-wx_WEGd+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-21 12:17 ` Mikko Rapeli
2015-04-09 16:00 ` Emil Velikov
2015-04-09 16:09 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 06/45] drm_mode.h: include stdint.h and linux/types.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 07/45] exynos_drm.h: include stdint.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 08/45] nouveau_drm.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 09/45] radeon_drm.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 10/45] r128_drm.h: include drm/drm.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 11/45] via_drm.h: include linux/types.h instead of non-existing via_drmclient.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 12/45] via_drm.h: hide struct via_file_private in userspace Mikko Rapeli
2015-02-16 23:05 ` [PATCH 13/45] savage_drm.h: include <drm/drm.h> Mikko Rapeli
2015-02-16 23:05 ` [PATCH 14/45] sis_drm.h: hide sis_file_private in userspace Mikko Rapeli
2015-02-16 23:05 ` [PATCH 15/45] dm-log-userspace.h: include stdint.h " Mikko Rapeli
2015-02-16 23:32 ` Mike Snitzer
[not found] ` <20150216233254.GA23033-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-02-16 23:48 ` Mikko Rapeli
[not found] ` <1424127948-22484-16-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:08 ` Arnd Bergmann
2015-02-17 13:38 ` Alasdair G Kergon
[not found] ` <20150217133806.GA5220-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2015-02-17 13:55 ` Arnd Bergmann
2015-03-10 22:48 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 16/45] hsi_char.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 17/45] ebtables.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 18/45] cld.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 21/45] scsi_bsg_fc.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 22/45] scsi_netlink.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 23/45] scsi_netlink_fc.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 24/45] hdspm.h: " Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-03-11 0:28 ` Mikko Rapeli
[not found] ` <20150311002812.GB12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-11 6:09 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 25/45] gntalloc.h: " Mikko Rapeli
[not found] ` <1424127948-22484-26-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-18 11:53 ` David Vrabel [this message]
[not found] ` <54E47D32.9040208-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2015-03-10 22:48 ` [Xen-devel] " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 26/45] gntdev.h: " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 27/45] include/uapi/linux/sysctl.h: include stdlib.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 28/45] include/uapi/asm-generic/ipcbuf.h: include linux/posix_types.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 30/45] include/uapi/asm-generic/shmbuf.h: include fixes Mikko Rapeli
2015-02-16 23:05 ` [PATCH 31/45] asm-generic/sembuf.h: include asm/posix_types.h and asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 32/45] drm/i810_drm.h: include drm/drm.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 33/45] include/uapi/asm-generic/signal.h: include stdlib.h in userspace Mikko Rapeli
[not found] ` <1424127948-22484-34-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:44 ` Arnd Bergmann
2015-03-10 22:58 ` Mikko Rapeli
[not found] ` <20150310225828.GZ12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-11 10:02 ` Arnd Bergmann
2015-02-16 23:05 ` [PATCH 34/45] include/uapi/asm-generic/signal.h: hide sigset_t definition " Mikko Rapeli
[not found] ` <1424127948-22484-35-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:16 ` Arnd Bergmann
2015-03-11 0:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 35/45] include/uapi/sound/asound.h: include stdlib.h " Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 36/45] include/uapi/linux/netfilter.h: include in.h and in6.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 37/45] include/uapi/linux/socket.h: include sys/socket.h in userspace Mikko Rapeli
[not found] ` <1424127948-22484-38-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:14 ` Arnd Bergmann
2015-03-11 0:38 ` Mikko Rapeli
[not found] ` <20150311003815.GC12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-11 0:59 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 38/45] include/uapi/linux/agpgart.h: include stdlib.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 40/45] include/uapi/sound/emu10k1.h: include sound/asound.h Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 41/45] include/uapi/sound/emu10k1.h: hide gpr_valid, tram_valid and code_valid in userspace Mikko Rapeli
[not found] ` <1424127948-22484-42-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 6:27 ` Takashi Iwai
[not found] ` <s5h4mqlqch1.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2015-03-11 1:22 ` Mikko Rapeli
[not found] ` <20150311012204.GE12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-11 6:11 ` Takashi Iwai
[not found] ` <s5h4mpsnjw9.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2015-03-11 9:46 ` Arnd Bergmann
2015-03-12 6:11 ` Takashi Iwai
[not found] ` <s5hr3sun3rv.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2015-03-12 8:45 ` Arnd Bergmann
2015-03-12 9:05 ` Takashi Iwai
[not found] ` <1424127948-22484-1-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-16 23:05 ` [PATCH 19/45] rds.h: include stdint.h " Mikko Rapeli
2015-02-16 23:05 ` [PATCH 20/45] sctp.h: " Mikko Rapeli
[not found] ` <1424127948-22484-21-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 13:11 ` Neil Horman
2015-02-18 15:48 ` Daniel Borkmann
[not found] ` <54E4B434.3030302-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2015-02-18 16:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 29/45] include/uapi/asm-generic/msgbuf.h: include asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 39/45] include/uapi/sound/asequencer.h: include sound/asound.h Mikko Rapeli
2015-02-17 6:46 ` Takashi Iwai
2015-02-16 23:05 ` [PATCH 42/45] include/uapi/linux/rds.h: include linux/socket.h and linux/types.h always Mikko Rapeli
2015-02-16 23:05 ` [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h Mikko Rapeli
2015-02-17 0:02 ` Jan Engelhardt
[not found] ` <alpine.LSU.2.11.1502170101520.32748-G+YmpvGGOO3H9RFtKMg/Ng@public.gmane.org>
2015-03-11 1:49 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 44/45] nf_conntrack_tuple_common.h: include linux/types.h and linux/netfilter.h Mikko Rapeli
2015-02-16 23:05 ` [PATCH 45/45] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h Mikko Rapeli
2015-02-17 9:10 ` Arnd Bergmann
2015-03-11 1:59 ` Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E47D32.9040208@citrix.com \
--to=david.vrabel-sxgqhf6nn4dqt0dzr+alfa@public.gmane.org \
--cc=boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mikko.rapeli-X3B1VOXEql0@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).