From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers Date: Mon, 23 Mar 2015 22:05:31 +0000 Message-ID: <55108E2B.7050305@linaro.org> References: <1426240157-2383-1-git-send-email-srinivas.kandagatla@linaro.org> <1426240214-2434-1-git-send-email-srinivas.kandagatla@linaro.org> <20150323210918.GS14954@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150323210918.GS14954-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maxime Ripard , Rob Herring , Pawel Moll , Kumar Gala , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On 23/03/15 21:09, Mark Brown wrote: > On Fri, Mar 13, 2015 at 09:50:14AM +0000, Srinivas Kandagatla wrote: > > A couple of *very* minor points below, otherwise this looks OK to me. > Thankyou for the review. >> +struct eeprom_device *eeprom_register(struct eeprom_config *config) >> +{ >> + struct eeprom_device *eeprom; >> + int rval; >> + >> + if (!config->regmap || !config->size) { >> + dev_err(config->dev, "Regmap not found\n"); >> + return ERR_PTR(-EINVAL); >> + } > > You have a struct device in the config and the regmap API has > dev_get_regmap() which for most devices that don't have multiple regmaps > will give the right regmap. It would be nice to support this as a > convenience for users. Yes, sure that makes sense, I will give it a try. > >> + eeprom = kzalloc(sizeof(*eeprom), GFP_KERNEL); >> + if (!eeprom) >> + return ERR_PTR(-ENOMEM); > > ... > >> + rval = device_add(&eeprom->dev); >> + if (rval) >> + return ERR_PTR(rval); > > Don't you need a kfree() if device_add() fails? I will fix it in next version. --srini > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html