From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next] tc: bpf: add checksum helpers Date: Thu, 02 Apr 2015 17:00:47 +0200 Message-ID: <551D599F.30408@iogearbox.net> References: <1427933533-14394-1-git-send-email-ast@plumgrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427933533-14394-1-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexei Starovoitov , "David S. Miller" Cc: Jiri Pirko , Jamal Hadi Salim , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On 04/02/2015 02:12 AM, Alexei Starovoitov wrote: > Commit 608cd71a9c7c ("tc: bpf: generalize pedit action") has added the > possibility to mangle packet data to BPF programs in the tc pipeline. > This patch adds two helpers bpf_l3_csum_replace() and bpf_l4_csum_replace() > for fixing up the protocol checksums after the packet mangling. > > It also adds 'flags' argument to bpf_skb_store_bytes() helper to avoid > unnecessary checksum recomputations when BPF programs adjusting l3/l4 > checksums and documents all three helpers in uapi header. > > Moreover, a sample program is added to show how BPF programs can make use > of the mangle and csum helpers. > > Signed-off-by: Alexei Starovoitov I think in future we need to find a better place for these helpers, as they are for cls_bpf and act_bpf. Acked-by: Daniel Borkmann