linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: "Andreas Färber" <afaerber@suse.de>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	u.kleine-koenig@pengutronix.de, geert@linux-m68k.org,
	"Rob Herring" <robh+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl,
	andy.shevchenko@gmail.com, cw00.choi@samsung.com,
	"Russell King" <linux@arm.linux.org.uk>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	joe@perches.com
Cc: Jonathan Corbet <corbet@lwn.net>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Antti Palosaari <crope@iki.fi>, Tejun Heo <tj@kernel.org>,
	Will Deacon <will.deacon@arm.com>,
	Nikolay Borisov <Nikolay.Borisov@arm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Kees Cook <keescook@chromium.org>, Michal Marek <mmarek@suse.cz>,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arch@vger.kerne
Subject: Re: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver
Date: Tue, 07 Apr 2015 13:05:39 -0400	[thread overview]
Message-ID: <55240E63.3040502@hurleysoftware.com> (raw)
In-Reply-To: <55240B2C.3020102@suse.de>

Hi Andreas,

On 04/07/2015 12:51 PM, Andreas Färber wrote:
> Am 07.04.2015 um 18:30 schrieb Maxime Coquelin:
>> This drivers adds support to the STM32 USART controller, which is a
>> standard serial driver.
>>
>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> ---
>>  drivers/tty/serial/Kconfig       |  17 +
>>  drivers/tty/serial/Makefile      |   1 +
>>  drivers/tty/serial/stm32-usart.c | 735 +++++++++++++++++++++++++++++++++++++++
>>  include/uapi/linux/serial_core.h |   3 +
>>  4 files changed, 756 insertions(+)
>>  create mode 100644 drivers/tty/serial/stm32-usart.c
> [...]
>> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
>> new file mode 100644
>> index 0000000..4adc430
>> --- /dev/null
>> +++ b/drivers/tty/serial/stm32-usart.c
> [...]
>> +#define DRIVER_NAME "stm32-usart"
>> +#define STM32_SERIAL_NAME "ttyS"
> 
> I'm surprised no one has complained about ttyS yet. Doesn't that need to
> be unique, such as ttySTM (efm32 uses ttyefm), to avoid clashes between
> serial drivers? ttyS was exclusive to the 8250 driver, I thought.

As long as this platform doesn't support 8250 h/w, I don't care; and
by the time this platform is ready for multiconfig, I'll have ttyS
coexistence fixed.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-04-07 17:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 16:30 [PATCH v6 00/15] Add support to STMicroelectronics STM32 family Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 01/15] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 02/15] ARM: ARMv7-M: Enlarge vector table up to 256 entries Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 04/15] clocksource/drivers: Add ARM System timer driver Maxime Coquelin
     [not found]   ` <1428424234-28572-5-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-09 10:52     ` Daniel Lezcano
2015-04-07 16:30 ` [PATCH v6 05/15] dt-bindings: Document the STM32 reset bindings Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 06/15] drivers: reset: Add STM32 reset driver Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 08/15] clockevents/drivers: Add STM32 Timer driver Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 11/15] ARM: Add STM32 family machine Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 12/15] ARM: dts: Add ARM System timer as clockevent in armv7m Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 13/15] ARM: dts: Introduce STM32F429 MCU Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 14/15] ARM: configs: Add STM32 defconfig Maxime Coquelin
2015-04-07 16:30 ` [PATCH v6 15/15] MAINTAINERS: Add entry for STM32 MCUs Maxime Coquelin
     [not found] ` <1428424234-28572-1-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-07 16:30   ` [PATCH v6 03/15] dt-bindings: Document the ARM System timer bindings Maxime Coquelin
2015-04-07 16:30   ` [PATCH v6 07/15] dt-bindings: Document the STM32 " Maxime Coquelin
2015-04-07 16:30   ` [PATCH v6 09/15] dt-bindings: Document the STM32 USART bindings Maxime Coquelin
2015-04-07 19:26     ` Rob Herring
2015-04-07 16:30   ` [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
     [not found]     ` <1428424234-28572-11-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-07 16:36       ` Andy Shevchenko
2015-04-07 16:51     ` Andreas Färber
2015-04-07 17:05       ` Peter Hurley [this message]
2015-04-09 13:04     ` Vladimir Zapolskiy
     [not found]       ` <552678E7.4040107-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2015-04-28 12:13         ` Maxime Coquelin
2015-04-08  9:14   ` [PATCH v6 00/15] Add support to STMicroelectronics STM32 family Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55240E63.3040502@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=Nikolay.Borisov@arm.com \
    --cc=afaerber@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=crope@iki.fi \
    --cc=cw00.choi@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=jslaby@suse.cz \
    --cc=keescook@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kerne \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mmarek@suse.cz \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=pebolle@tiscali.nl \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=stefan@agner.ch \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).