linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Yaniv Gardi <ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	santoshsy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-scsi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	gbroner-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	draviv-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	Noa Rubens <noag-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Raviv Shvili <rshvili-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Vinayak Holikatti
	<vinholikatti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"James E.J. Bottomley" <JBottomley-wo1vFcy6AUs@public.gmane.org>,
	"open list:ABI/API"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v4] scsi: ufs: add ioctl interface for query request
Date: Sun, 11 Oct 2015 21:13:17 +0200	[thread overview]
Message-ID: <5532251.sHP7i3bdrH@wuerfel> (raw)
In-Reply-To: <1444562547-3100-1-git-send-email-ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On Sunday 11 October 2015 14:22:12 Yaniv Gardi wrote:
>   * @cookie: cookie data
> @@ -5106,6 +5308,10 @@ static struct scsi_host_template ufshcd_driver_template = {
>         .eh_device_reset_handler = ufshcd_eh_device_reset_handler,
>         .eh_host_reset_handler   = ufshcd_eh_host_reset_handler,
>         .eh_timed_out           = ufshcd_eh_timed_out,
> +       .ioctl                  = ufshcd_ioctl,
> +#ifdef CONFIG_COMPAT
> +       .compat_ioctl           = ufshcd_ioctl,
> +#endif
>         .this_id                = -1,
>         .sg_tablesize           = SG_ALL,
>         .cmd_per_lun            = UFSHCD_CMD_PER_LUN,
> 

I think I commented before that the #ifdef here is not needed and should
just be removed. Otherwise it looks ok to me now.

	Arnd

  parent reply	other threads:[~2015-10-11 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 11:22 [PATCH v4] scsi: ufs: add ioctl interface for query request Yaniv Gardi
     [not found] ` <1444562547-3100-1-git-send-email-ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-10-11 19:13   ` Arnd Bergmann [this message]
2015-10-22  6:36   ` subhashj-sgV2jX0FEOL9JmXXK+q4OQ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5532251.sHP7i3bdrH@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=JBottomley-wo1vFcy6AUs@public.gmane.org \
    --cc=James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
    --cc=draviv-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=gbroner-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=noag-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=rshvili-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=santoshsy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=vinholikatti-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).