From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v5 10/11] nvmem: sunxi: Move the SID driver to the nvmem framework Date: Tue, 16 Jun 2015 16:04:18 -0700 Message-ID: <5580AB72.6010909@codeaurora.org> References: <1432226535-8640-1-git-send-email-srinivas.kandagatla@linaro.org> <1432226733-9243-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432226733-9243-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinivas Kandagatla , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Maxime Ripard , Rob Herring , Kumar Gala , Mark Brown , s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Greg Kroah-Hartman , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org List-Id: linux-api@vger.kernel.org On 05/21/2015 09:45 AM, Srinivas Kandagatla wrote: > diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile > index caea611..cc46791 100644 > --- a/drivers/nvmem/Makefile > +++ b/drivers/nvmem/Makefile > @@ -9,3 +9,5 @@ nvmem_core-y += nvmem-mmio.o > # Devices > obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o > nvmem_qfprom-y := qfprom.o > +obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem-sunxi-sid.o > +nvmem-sunxi-sid-y := sunxi-sid.o Oh I see, so the module has nvmem- in the name. Isn't there some way to add a rule to do that for all provider drivers? > diff --git a/drivers/nvmem/sunxi-sid.c b/drivers/nvmem/sunxi-sid.c > new file mode 100644 > index 0000000..5bfce35 > --- /dev/null > +++ b/drivers/nvmem/sunxi-sid.c > @@ -0,0 +1,64 @@ > +/* > + * Allwinner sunXi SoCs Security ID support. > + * > + * Copyright (c) 2013 Oliver Schinagl > + * Copyright (C) 2014 Maxime Ripard > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */ > + > +#include > +#include > +#include "nvmem-mmio.h" > + > +static bool sunxi_sid_writeable_reg(struct device *dev, unsigned int reg) > +{ > + return false; > +} > + > +static struct nvmem_config econfig = { const? > + .name = "sunix-sid", > + .owner = THIS_MODULE, > +}; > + > +static struct regmap_config sunxi_sid_regmap_config = { const? > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > + .writeable_reg = sunxi_sid_writeable_reg, > +}; > + > +static struct nvmem_mmio_data sunxi_data = { const? > + .nvmem_config = &econfig, > + .regmap_config = &sunxi_sid_regmap_config, > +}; > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project