From: Beata Michalska <b.michalska@samsung.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-FSDevel <linux-fsdevel@vger.kernel.org>,
linux-api@vger.kernel.org, Greg Kroah <greg@kroah.com>,
jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca,
Hugh Dickins <hughd@google.com>,
lczerner@redhat.com, hch@infradead.org,
linux-ext4@vger.kernel.org, Linux-MM <linux-mm@kvack.org>,
kyungmin.park@samsung.com, kmpark@infradead.org
Subject: Re: [RFC v3 4/4] shmem: Add support for generic FS events
Date: Wed, 17 Jun 2015 11:23:40 +0200 [thread overview]
Message-ID: <55813C9C.1010608@samsung.com> (raw)
In-Reply-To: <CALq1K=L-DWP5avgXtc0p5=D_M8tXm+Y45DphP7G9QBYo-5sXFA@mail.gmail.com>
On 06/17/2015 08:08 AM, Leon Romanovsky wrote:
>> }
>> - if (error == -ENOSPC && !once++) {
>> + if (error == -ENOSPC) {
>> + if (!once++) {
>> info = SHMEM_I(inode);
>> spin_lock(&info->lock);
>> shmem_recalc_inode(inode);
>> spin_unlock(&info->lock);
>> goto repeat;
>> + } else {
>> + fs_event_notify(inode->i_sb, FS_WARN_ENOSPC);
>> + }
>> }
>
> Very minor remark, please fix indentation.
>
I will, thank You.
BR
Beata
prev parent reply other threads:[~2015-06-17 9:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 13:09 [RFC v3 0/4] fs: Add generic file system event notifications Beata Michalska
2015-06-16 13:09 ` [RFC v3 1/4] " Beata Michalska
2015-06-17 23:06 ` Dave Chinner
2015-06-18 8:25 ` Beata Michalska
2015-06-19 0:03 ` Dave Chinner
2015-06-19 17:28 ` Beata Michalska
2015-06-19 23:21 ` Dave Chinner
2015-06-22 15:46 ` Beata Michalska
2015-06-18 11:17 ` Kinglong Mee
2015-06-18 14:50 ` Beata Michalska
[not found] ` <1434460173-18427-2-git-send-email-b.michalska-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-06-16 16:21 ` Al Viro
2015-06-17 9:22 ` Beata Michalska
2015-06-24 8:47 ` Dmitry Monakhov
2015-06-24 15:31 ` Beata Michalska
2015-06-24 16:26 ` Steve French
2015-06-26 7:30 ` Beata Michalska
2015-07-22 15:55 ` Bartlomiej Zolnierkiewicz
2015-07-30 8:22 ` Beata Michalska
2015-06-16 13:09 ` [RFC v3 2/4] ext4: Add helper function to mark group as corrupted Beata Michalska
2015-07-22 10:40 ` Bartlomiej Zolnierkiewicz
[not found] ` <1434460173-18427-1-git-send-email-b.michalska-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-06-16 13:09 ` [RFC v3 3/4] ext4: Add support for generic FS events Beata Michalska
2015-06-17 6:15 ` Leon Romanovsky
2015-06-17 9:25 ` Beata Michalska
2015-06-16 13:09 ` [RFC v3 4/4] shmem: " Beata Michalska
2015-06-17 6:08 ` Leon Romanovsky
2015-06-17 9:23 ` Beata Michalska [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55813C9C.1010608@samsung.com \
--to=b.michalska@samsung.com \
--cc=adilger.kernel@dilger.ca \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kmpark@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=lczerner@redhat.com \
--cc=leon@leon.nu \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).