From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v6 0/9] Add simple NVMEM Framework via regmap. Date: Wed, 24 Jun 2015 14:03:09 +0100 Message-ID: <558AAA8D.8030209@linaro.org> References: <1435014459-26138-1-git-send-email-srinivas.kandagatla@linaro.org> <235181230.251177.1435088854197.JavaMail.open-xchange@oxbsltgw00.schlund.de> <558A7C92.2040102@linaro.org> <558AA2E2.1010606@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558AA2E2.1010606-eS4NqCHxEME@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Greg Kroah-Hartman , wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kumar Gala , Rob Herring , sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, Maxime Ripard , pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown List-Id: linux-api@vger.kernel.org On 24/06/15 13:30, Stefan Wahren wrote: >> >If the question is just about hexdump, then hexdump itself can read >> >file from given offset and size. > yes, this is my question at first. Let me show the difference between > the current implementation and my expectations as a user. > > $ hexdump /sys/class/nvmem/mxs-ocotp/nvmem > > Current implementation: dump the complete register range defined in DT > Its dumping the range which is specified in the provider regmap. If the requirement is to dump only particular range, this has to be made explicit while creating regmap, which is to specify the base address to start from "First data register" and max_register to be "Last data register "- "First data register" > User expectation: dump only the data from OCOTP block > > Let me explain it for i.MX28 OCOTP > > 0x8002c000 // Start of OCOTP register block (defined in DT) > > 0x8002c020 // First data register > > 0x8002c290 // Last data register > > 0x8002dfff // End of OCOTP register block (defined in DT) > > My knowledge about regmap is limited, but how can i achieve that hexdump > give me only the data registers? From my understanding this should be > handled in regmap and not in the read function. Setup the base and regmap_config correctly in the provider driver before calling regmap_init_mmio(). Let me know if you need more details. --srini > > Are my expectations about the raw access wrong? > >