From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v8 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Date: Tue, 21 Jul 2015 10:59:00 -0700 Message-ID: <55AE8864.6020608@codeaurora.org> References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403392-4136-1-git-send-email-srinivas.kandagatla@linaro.org> <55AD6412.9070205@codeaurora.org> <55AE13D8.6020301@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55AE13D8.6020301@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Kandagatla Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Rob Herring , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, pantelis.antoniou@konsulko.com, mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com, Maxime Ripard List-Id: linux-api@vger.kernel.org On 07/21/2015 02:41 AM, Srinivas Kandagatla wrote: > Thanks Stephen for review, > > On 20/07/15 22:11, Stephen Boyd wrote: >> On 07/20/2015 07:43 AM, Srinivas Kandagatla wrote: >>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c >>> new file mode 100644 >>> index 0000000..bde5528 >>> --- /dev/null >>> +++ b/drivers/nvmem/core.c >>> @@ -0,0 +1,384 @@ >>> >>> + >>> +static int nvmem_add_cells(struct nvmem_device *nvmem, >>> + const struct nvmem_config *cfg) >>> +{ >>> + struct nvmem_cell **cells; >>> + const struct nvmem_cell_info *info = cfg->cells; >>> + int i, rval; >>> + >>> + cells = kzalloc(sizeof(*cells) * cfg->ncells, GFP_KERNEL); >> >> kcalloc? > > Only reason for using kzalloc is to give the code more flexibility to > free any pointer in the array in case of errors. Still lost. The arrays are allocated down below in the for loop. This is allocating a bunch of pointers so using kcalloc() here avoids problems with overflows causing kzalloc() to allocate fewer pointers than requested. I'm not suggesting we replace the for loop with a kcalloc, just this single line. > >> >>> + if (!cells) >>> + return -ENOMEM; >>> + >>> + for (i = 0; i < cfg->ncells; i++) { >>> + cells[i] = kzalloc(sizeof(**cells), GFP_KERNEL); >>> + if (!cells[i]) { >>> + rval = -ENOMEM; >>> + goto err; >>> + } >>> + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project