From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH v8 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework Date: Thu, 23 Jul 2015 17:18:14 +0200 Message-ID: <55B105B6.7000502@i2se.com> References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437403462-4432-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinivas Kandagatla Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Greg Kroah-Hartman , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, Mark Brown , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, Maxime Ripard , wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-api@vger.kernel.org Hi Srinivas, Am 20.07.2015 um 16:44 schrieb Srinivas Kandagatla: > From: Maxime Ripard > > Now that we have the nvmem framework, we can consolidate the common > driver code. Move the driver to the framework, and hopefully, it will > fix the sysfs file creation race. > > Signed-off-by: Maxime Ripard > [srinivas.kandagatla: Moved to regmap based EEPROM framework] > Signed-off-by: Srinivas Kandagatla > --- > Documentation/ABI/testing/sysfs-driver-sunxi-sid | 22 --- > .../bindings/misc/allwinner,sunxi-sid.txt | 17 --- > .../bindings/nvmem/allwinner,sunxi-sid.txt | 21 +++ > drivers/misc/eeprom/Kconfig | 13 -- > drivers/misc/eeprom/Makefile | 1 - > drivers/misc/eeprom/sunxi_sid.c | 156 -------------------- > drivers/nvmem/Kconfig | 11 ++ > drivers/nvmem/Makefile | 2 + > drivers/nvmem/sunxi_sid.c | 159 +++++++++++++++++++++ > 9 files changed, 193 insertions(+), 209 deletions(-) > delete mode 100644 Documentation/ABI/testing/sysfs-driver-sunxi-sid > delete mode 100644 Documentation/devicetree/bindings/misc/allwinner,sunxi-sid.txt > create mode 100644 Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > delete mode 100644 drivers/misc/eeprom/sunxi_sid.c > create mode 100644 drivers/nvmem/sunxi_sid.c > > [...] > diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile > index ff44fe9..4328b93 100644 > --- a/drivers/nvmem/Makefile > +++ b/drivers/nvmem/Makefile > @@ -8,3 +8,5 @@ nvmem_core-y := core.o > # Devices > obj-$(CONFIG_QCOM_QFPROM) += nvmem_qfprom.o > nvmem_qfprom-y := qfprom.o > +obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o > +nvmem_sunxi_sid-y := sunxi_sid.o is it really necessary to have 2 lines for a single driver? Why not the following line? obj-$(CONFIG_NVMEM_SUNXI_SID) += sunxi_sid.o Regards Stefan