From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [Xen-devel] [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up Date: Tue, 28 Jul 2015 18:19:09 +0100 Message-ID: <55B7B98D.3050008@citrix.com> References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <1438095769-2560-9-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438095769-2560-9-git-send-email-julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julien Grall , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Russell King , ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , David Vrabel , "H. Peter Anvin" , Boris Ostrovsky , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-api@vger.kernel.org On 28/07/15 16:02, Julien Grall wrote: > The privcmd code is mixing the usage of GFN and MFN within the same > functions which make the code difficult to understand when you only work > with auto-translated guests. > > The privcmd driver is only dealing with GFN so replace all the mention > of MFN into GFN. > > The ioctl structure used to map foreign change has been left unchanged > given that the userspace is using it. Nonetheless, add a comment to > explain the expected value within the "mfn" field. Reviewed-by: David Vrabel David