From: Yuan Sun <sunyuan3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org
Cc: keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org,
wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org,
bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
tim.bird-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org,
josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
andrej.skvortzov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sjayaram-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org,
treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
naresh.kamboju-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
alexey.kodanev-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org,
peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] kselftest: replace $(RM) with rm -f command
Date: Mon, 28 Sep 2015 15:26:54 +0800 [thread overview]
Message-ID: <5608EBBE.6090800@huawei.com> (raw)
In-Reply-To: <1443406217-137773-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
See the in-line comment.
On 2015/9/28 10:10, Wang Long wrote:
> Some test's Makefile using "$(RM)" while the other's
> using "rm -f". It is better to use one of them in all
> tests.
>
> "rm -f" is better, because it is less magic, and everyone
> konws what is does.
>
> Signed-off-by: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> tools/testing/selftests/capabilities/Makefile | 2 +-
> tools/testing/selftests/kcmp/Makefile | 2 +-
> tools/testing/selftests/membarrier/Makefile | 2 +-
> tools/testing/selftests/memfd/Makefile | 2 +-
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/seccomp/Makefile | 2 +-
> tools/testing/selftests/size/Makefile | 2 +-
> tools/testing/selftests/vm/Makefile | 2 +-
> tools/testing/selftests/x86/Makefile | 2 +-
> tools/testing/selftests/zram/Makefile | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
> index 8c8f0c1..dcc1972 100644
> --- a/tools/testing/selftests/capabilities/Makefile
> +++ b/tools/testing/selftests/capabilities/Makefile
> @@ -12,7 +12,7 @@ CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
> all: $(TARGETS)
>
> clean:
> - $(RM) $(TARGETS)
> + rm -f $(TARGETS)
>
> $(TARGETS): %: %.c
> $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
> index 2ae7450..2deaee0 100644
> --- a/tools/testing/selftests/kcmp/Makefile
> +++ b/tools/testing/selftests/kcmp/Makefile
> @@ -7,4 +7,4 @@ TEST_PROGS := kcmp_test
> include ../lib.mk
>
> clean:
> - $(RM) kcmp_test kcmp-test-file
> + rn -f kcmp_test kcmp-test-file
It should be rm, not rn.
> diff --git a/tools/testing/selftests/membarrier/Makefile b/tools/testing/selftests/membarrier/Makefile
> index a1a9708..f23fc58 100644
> --- a/tools/testing/selftests/membarrier/Makefile
> +++ b/tools/testing/selftests/membarrier/Makefile
> @@ -7,4 +7,4 @@ all: $(TEST_PROGS)
> include ../lib.mk
>
> clean:
> - $(RM) $(TEST_PROGS)
> + rm -f $(TEST_PROGS)
> diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
> index 3e7eb79..068fa93 100644
> --- a/tools/testing/selftests/memfd/Makefile
> +++ b/tools/testing/selftests/memfd/Makefile
> @@ -19,4 +19,4 @@ run_fuse: build_fuse
> @./run_fuse_test.sh || echo "fuse_test: [FAIL]"
>
> clean:
> - $(RM) memfd_test fuse_test
> + rm -f memfd_test fuse_test
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index fac4782..ec7eaa4 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -16,4 +16,4 @@ TEST_FILES := $(NET_PROGS)
> include ../lib.mk
>
> clean:
> - $(RM) $(NET_PROGS)
> + rm -f $(NET_PROGS)
> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> index 8401e87..c16072a 100644
> --- a/tools/testing/selftests/seccomp/Makefile
> +++ b/tools/testing/selftests/seccomp/Makefile
> @@ -7,4 +7,4 @@ all: $(TEST_PROGS)
> include ../lib.mk
>
> clean:
> - $(RM) $(TEST_PROGS)
> + rm -f $(TEST_PROGS)
> diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile
> index bbd0b53..cefe914 100644
> --- a/tools/testing/selftests/size/Makefile
> +++ b/tools/testing/selftests/size/Makefile
> @@ -8,4 +8,4 @@ TEST_PROGS := get_size
> include ../lib.mk
>
> clean:
> - $(RM) get_size
> + rm -f get_size
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index 3c53cac..26663c7 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -24,4 +24,4 @@ TEST_FILES := $(BINARIES)
> include ../lib.mk
>
> clean:
> - $(RM) $(BINARIES)
> + rm -f $(BINARIES)
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index 29089b2..48b2406 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -32,7 +32,7 @@ all_32: $(BINARIES_32)
> all_64: $(BINARIES_64)
>
> clean:
> - $(RM) $(BINARIES_32) $(BINARIES_64)
> + rm -f $(BINARIES_32) $(BINARIES_64)
>
> $(TARGETS_C_32BIT_ALL:%=%_32): %_32: %.c
> $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
> diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile
> index 29d8034..e1591c8 100644
> --- a/tools/testing/selftests/zram/Makefile
> +++ b/tools/testing/selftests/zram/Makefile
> @@ -6,4 +6,4 @@ TEST_FILES := zram01.sh zram02.sh zram_lib.sh
> include ../lib.mk
>
> clean:
> - $(RM) err.log
> + rm -f err.log
prev parent reply other threads:[~2015-09-28 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150925154415.GC38748@vmdeb7>
2015-09-28 2:10 ` [PATCH] kselftest: replace $(RM) with rm -f command Wang Long
[not found] ` <1443406217-137773-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-09-28 3:16 ` Mathieu Desnoyers
[not found] ` <1201012824.5792.1443410213729.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-29 9:57 ` Michael Ellerman
[not found] ` <1443520665.11041.1.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-09-29 11:21 ` [PATCH] kselftest: replace rm -f command with $(RM) Wang Long
2015-09-29 17:45 ` [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook
2015-10-03 4:38 ` Darren Hart
2015-10-03 14:11 ` Mathieu Desnoyers
[not found] ` <1486799898.16862.1443881517178.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-10-03 17:55 ` Josh Triplett
2015-10-03 18:05 ` Mathieu Desnoyers
2015-09-28 7:26 ` Yuan Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5608EBBE.6090800@huawei.com \
--to=sunyuan3-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alexey.kodanev-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=andrej.skvortzov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
--cc=naresh.kamboju-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=sjayaram-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
--cc=tim.bird-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).