From: Peter Hurley <peter@hurleysoftware.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-serial@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Kevin Cernekee <cernekee@gmail.com>, Jiri Slaby <jslaby@suse.com>,
Rob Herring <robh@kernel.org>,
linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org,
Eddie Huang <eddie.huang@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] serial: support register interface with 16-bit stride for console
Date: Tue, 20 Oct 2015 09:42:23 -0400 [thread overview]
Message-ID: <562644BF.4020204@hurleysoftware.com> (raw)
In-Reply-To: <1445312189-28876-2-git-send-email-yamada.masahiro@socionext.com>
On 10/19/2015 11:36 PM, Masahiro Yamada wrote:
> Currently, 8-bit (MMIO) and 32-bit (MMIO32) register strides are
> supported for the 8250 console, but 16-bit (MMIO16) stride is not.
> The 8250 UART device on my board is connected to a 16-bit bus
> (reg-shift = <1>) and I am eager to use earlycon with it.
>
> Refer to arch/arm/boot/dts/uniphier-support-card.dtsi:
>
> serialsc: uart@000b0000 {
> compatible = "ns16550a";
> reg = <0x000b0000 0x20>;
> clock-frequency = <12288000>;
> reg-shift = <1>;
> };
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Do not change userspace-exported macros
>
> Documentation/kernel-parameters.txt | 9 +++++----
> drivers/tty/serial/8250/8250_early.c | 5 +++++
> drivers/tty/serial/8250/8250_port.c | 20 ++++++++++++++++++++
> drivers/tty/serial/earlycon.c | 15 +++++++++++----
> drivers/tty/serial/serial_core.c | 9 +++++++--
> include/linux/serial_core.h | 1 +
> include/uapi/linux/serial.h | 1 +
> 7 files changed, 50 insertions(+), 10 deletions(-)
[...]
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 603d2cc..325acce 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1819,8 +1819,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
> * @options: ptr for <options> field; NULL if not present (out)
> *
> * Decodes earlycon kernel command line parameters of the form
> - * earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> - * console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> + * earlycon=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> + * console=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> *
> * The optional form
> * earlycon=<name>,0x<addr>,<options>
This hunk fails to apply. Please rebase on top of tty-next branch of
Greg's tty.git tree (git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git)
Regards,
Peter Hurley
prev parent reply other threads:[~2015-10-20 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 3:36 [PATCH v2 0/2] serial: console: add two features Masahiro Yamada
[not found] ` <1445312189-28876-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-10-20 3:36 ` [PATCH v2 1/2] serial: support register interface with 16-bit stride for console Masahiro Yamada
2015-10-20 13:42 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562644BF.4020204@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=bigeasy@linutronix.de \
--cc=cernekee@gmail.com \
--cc=corbet@lwn.net \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).