From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Murzin Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Date: Mon, 08 Feb 2016 11:16:56 +0000 Message-ID: <56B87928.7020803@arm.com> References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160207071154.GA32017-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: arnd-r2nGTMty4D4@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jslaby-AlSwsSmVLrQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On 07/02/16 07:11, Greg KH wrote: >> + >> +#define SERIAL_NAME "ttyS" > > You can't be "ttyS", there's already a serial port named that, please > use a unique name and a new major/minor number (dynamic ideally). > Hi Greg, I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it back if you prefer that, but I'd be glad to know what I've been missing? [1] https://lkml.org/lkml/2015/12/13/8 Thanks Vladimir > thanks, > > greg k-h > >