From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: arnd@arndb.de, linux@arm.linux.org.uk, daniel.lezcano@linaro.org,
tglx@linutronix.de, u.kleine-koenig@pengutronix.de,
andy.shevchenko@gmail.com, mark.rutland@arm.com,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver
Date: Mon, 08 Feb 2016 17:17:57 +0000 [thread overview]
Message-ID: <56B8CDC5.5010504@arm.com> (raw)
In-Reply-To: <20160208165226.GA11593@kroah.com>
On 08/02/16 16:52, Greg KH wrote:
> On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote:
>> On 07/02/16 07:11, Greg KH wrote:
>>>> +
>>>> +#define SERIAL_NAME "ttyS"
>>>
>>> You can't be "ttyS", there's already a serial port named that, please
>>> use a unique name and a new major/minor number (dynamic ideally).
>>>
>>
>> Hi Greg,
>>
>> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
>> back if you prefer that, but I'd be glad to know what I've been missing?
>>
>> [1] https://lkml.org/lkml/2015/12/13/8
>
> Yeah, I was wrong, sorry about that, my fault.
>
I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"?
P.S.
Any chance you could look at the rest of the patch?
Cheers
Vladimir
> greg k-h
>
>
>
next prev parent reply other threads:[~2016-02-08 17:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 11:39 [PATCH v2 00/10] Support for Cortex-M Prototyping System Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin
[not found] ` <1454413199-26573-3-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-02 13:04 ` Thomas Gleixner
2016-02-02 14:06 ` Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 03/10] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
[not found] ` <1454413199-26573-5-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-07 7:11 ` Greg KH
[not found] ` <20160207071154.GA32017-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-02-08 11:16 ` Vladimir Murzin
[not found] ` <56B87928.7020803-5wv7dgnIgG8@public.gmane.org>
2016-02-08 16:52 ` Greg KH
2016-02-08 17:17 ` Vladimir Murzin [this message]
[not found] ` <56B8CDC5.5010504-5wv7dgnIgG8@public.gmane.org>
2016-02-08 17:28 ` Greg KH
2016-02-02 11:39 ` [PATCH v2 05/10] serial: mps2-uart: add support for early console Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 06/10] ARM: mps2: introduce MPS2 platform Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 07/10] ARM: mps2: add low-level debug support Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 08/10] ARM: configs: add MPS2 defconfig Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 10/10] ARM: dts: introduce MPS2 AN399/AN400 Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8CDC5.5010504@arm.com \
--to=vladimir.murzin@arm.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).