From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097A7C433DB for ; Fri, 19 Mar 2021 20:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C61236193D for ; Fri, 19 Mar 2021 20:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhCSUNK (ORCPT ); Fri, 19 Mar 2021 16:13:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbhCSUMs (ORCPT ); Fri, 19 Mar 2021 16:12:48 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31504C061760 for ; Fri, 19 Mar 2021 13:12:48 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id y5so2702832qkl.9 for ; Fri, 19 Mar 2021 13:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2L5XeWgBJ+XEPLrrdKtx3vbv3j5UBuIU/axgHtMtD1U=; b=FfCjiLegZS6r4KqBXwc8QkZcVpvnzC2a/NYJraJfXH6WXfF9DPn/gU+cQt0jUxhy1n ugBHxqRKaKNn4SMLPHyMFYXxcxWfOuUDD5zn/aT43iFPr4p0RoBytr5QDLYtSz08Onvf oSX+3/EtMLJ05rkVPMP1NSdBkMMHa3luEPLA+VWBsvXA+EPRT/cR21UVrYj3o7nlMyw2 xOGGwaGIi1evIa5TwMQ8y4uDMkU/4Ll3An1rGVi2n1h0a9M4g928kwyTn8Cu6OVP25I6 CXcMixC1Bdl4MRiKdV2u5BaoZHHbisJK879qg5lTACrXT4saQ/qfHHr6h1kU3TaIIRjU 24AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2L5XeWgBJ+XEPLrrdKtx3vbv3j5UBuIU/axgHtMtD1U=; b=F8a7gRhhPfpl9xBxK3kzmj69jV0eDKjXqZ9EnB/KHDX6HWXf/6/ZVS6Us7uFYUGeNb ni5fdM2mHSZYRkCwg7hglub+V7lNcRfgTeigU4mLbn+FkRg3aJ6e9m0nVsibghLxbwRE f+MFTyw/ZaMZNTNNbaLOOfWb0C5zgq2vxr9Fz3g1MmbJnm9B1zmY17tnPQNTCnzaC7yU LT6za726hHtJEM5jkrxz+CeOHdzpSxmdMNm4BrS4aIjetNq6lMOKkZgoC6jcbIlE2zRA 5hGhUVnba9xq9Cn/ZdJ/+3r0TmI50iDD5TcudDeCSc3hdr+9RQEfSf+cNS/IQJhiMc2/ 8vUg== X-Gm-Message-State: AOAM533/w4UCkHqrEEgZrtq3ljiVPCGf6BE5TU+IcO1iyhQ992p5nTCG Wr6iYqroj0FDLNq5fZ3xeHIzUg== X-Google-Smtp-Source: ABdhPJwxGI2geq5FeY/Q8HkTPU1B8WtSBqZShlZnvAWHlpeKa6DACRduzDhLIVYsjubqNLPWXBw5vw== X-Received: by 2002:a05:620a:14b3:: with SMTP id x19mr353016qkj.384.1616184767115; Fri, 19 Mar 2021 13:12:47 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id s133sm5375476qke.1.2021.03.19.13.12.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 13:12:46 -0700 (PDT) Subject: Re: [PATCH v8 00/10] fs: interface for directly reading/writing compressed data To: Linus Torvalds Cc: Omar Sandoval , linux-fsdevel , linux-btrfs , Al Viro , Christoph Hellwig , Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , Linux API , Kernel Team References: <8f741746-fd7f-c81a-3cdf-fb81aeea34b5@toxicpanda.com> From: Josef Bacik Message-ID: <58866f31-029f-3f70-55b6-8bda07ed6442@toxicpanda.com> Date: Fri, 19 Mar 2021 16:12:45 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 3/19/21 4:08 PM, Linus Torvalds wrote: > On Fri, Mar 19, 2021 at 11:21 AM Josef Bacik wrote: >> >> Can we get some movement on this? Omar is sort of spinning his wheels here >> trying to get this stuff merged, no major changes have been done in a few >> postings. > > I'm not Al, and I absolutely detest the IOCB_ENCODED thing, and want > more explanations of why this should be done that way, and pollute our > iov_iter handling EVEN MORE. > > Our iov_iter stuff isn't the most legible, and I don't understand why > anybody would ever think it's a good idea to spread what is clearly a > "struct" inside multiple different iov extents. > > Honestly, this sounds way more like an ioctl interface than > read/write. We've done that before. That's actually the way this started https://lore.kernel.org/linux-fsdevel/8eae56abb90c0fe87c350322485ce8674e135074.1567623877.git.osandov@fb.com/ it was suggested that Omar make it generic by Dave Chinner, hence this is the direction it took. I'll leave the rest of the comments for Omar to respond to himself. Thanks, Josef