From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCHv7 01/33] ns: Introduce Time Namespace Date: Wed, 16 Oct 2019 11:44:38 +0100 Message-ID: <5f4c2f29-ca68-b19c-017f-d23730f6e871@arm.com> References: <20191011012341.846266-1-dima@arista.com> <20191011012341.846266-2-dima@arista.com> <80af93da-d497-81de-2a2a-179bb3bc852d@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andrei Vagin , Adrian Reber , Andy Lutomirski , Arnd Bergmann , Christian Brauner , Cyrill Gorcunov , "Eric W. Biederman" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jeff Dike , Oleg Nesterov , Pavel Emelyanov , Shuah Khan , containers@lists.linux-foundation.org, criu@openvz.org, linux-api@vger.kernel.org, x86@kernel.org, Andrei Vagin List-Id: linux-api@vger.kernel.org On 10/16/19 11:39 AM, Thomas Gleixner wrote: > On Wed, 16 Oct 2019, Vincenzo Frascino wrote: > > < Trim 250+ lines ( 3+ pages) of pointlessly wasted electrons > > >>> --- a/init/Kconfig >>> +++ b/init/Kconfig >>> @@ -1096,6 +1096,13 @@ config UTS_NS >>> In this namespace tasks see different info provided with the >>> uname() system call >>> >>> +config TIME_NS >>> + bool "TIME namespace" >>> + default y >> >> Having CONFIG_TIME_NS "default y" makes so that the option is selected even on >> the architectures that have no support for time namespaces. >> The direct consequence is that the fallbacks defined in this patch are never >> selected and this ends up in kernel compilation errors due to missing symbols. >> >> The error below shows what happens on arm64 (similar behavior on other >> architectures): >> >> aarch64-linux-gnu-ld: kernel/time/namespace.o: in function `timens_on_fork': >> kernel/time/namespace.c:321: undefined reference to `vdso_join_timens' >> >> My proposal is to keep TIME_NS "default n" (just remove "default y"), let the >> architectures that enable time namespaces select it and make CONFIG_TIME_NS >> select GENERIC_VDSO_TIME_NS if arch has HAVE_GENERIC_VDSO. > > Nah. > > config TIME_NS > bool "TIME namespace" > depends on GENERIC_VDSO_TIME_NS > default y > > and in lib/vdso/Kconfig > > config GENERIC_VDSO_TIME_NS > bool > > and let architectures which have support for the VDSO bits select it. > Agreed, this is even better. > < Trim another gazillion of useless lines > > > See: https://people.kernel.org/tglx/notes-about-netiquette > > Thanks, > > tglx > -- Regards, Vincenzo