Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma

Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma

[Ying Han]

On Mon, Jan 5, 2009 at 3:39 PM, Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> From: Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> Fix 32bit binary get 64bit stack vma offset.
>
> 32bit binary running on 64bit system, the /proc/pid/maps shows for the
> vma represents stack get a 64bit adress:
> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack]
>
> Signed-off-by:  Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> fs/exec.c                     |    5 +-
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 4e834f1..8c3eff4 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -517,6 +517,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>        unsigned long length = old_end - old_start;
>        unsigned long new_start = old_start - shift;
>        unsigned long new_end = old_end - shift;
> +       unsigned long new_pgoff = new_start >> PAGE_SHIFT;
>        struct mmu_gather *tlb;
>
>        BUG_ON(new_start > new_end);
> @@ -531,7 +532,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>        /*
>         * cover the whole range: [new_start, old_end)
>         */
> -       vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL);
> +       vma_adjust(vma, new_start, old_end, new_pgoff, NULL);
>
>        /*
>         * move the page tables downwards, on failure we rely on
> @@ -564,7 +565,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>        /*
>         * shrink the vma to just the new range.
>         */
> -       vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL);
> +       vma_adjust(vma, new_start, new_end, new_pgoff, NULL);
>
>        return 0;
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma

[Ying Han]

friendly ping...

On Thu, Jan 8, 2009 at 6:40 PM, Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, Jan 5, 2009 at 3:39 PM, Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>> From: Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>>
>> Fix 32bit binary get 64bit stack vma offset.
>>
>> 32bit binary running on 64bit system, the /proc/pid/maps shows for the
>> vma represents stack get a 64bit adress:
>> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack]
>>
>> Signed-off-by:  Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>>
>> fs/exec.c                     |    5 +-
>>
>> diff --git a/fs/exec.c b/fs/exec.c
>> index 4e834f1..8c3eff4 100644
>> --- a/fs/exec.c
>> +++ b/fs/exec.c
>> @@ -517,6 +517,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>>        unsigned long length = old_end - old_start;
>>        unsigned long new_start = old_start - shift;
>>        unsigned long new_end = old_end - shift;
>> +       unsigned long new_pgoff = new_start >> PAGE_SHIFT;
>>        struct mmu_gather *tlb;
>>
>>        BUG_ON(new_start > new_end);
>> @@ -531,7 +532,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>>        /*
>>         * cover the whole range: [new_start, old_end)
>>         */
>> -       vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL);
>> +       vma_adjust(vma, new_start, old_end, new_pgoff, NULL);
>>
>>        /*
>>         * move the page tables downwards, on failure we rely on
>> @@ -564,7 +565,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>>        /*
>>         * shrink the vma to just the new range.
>>         */
>> -       vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL);
>> +       vma_adjust(vma, new_start, new_end, new_pgoff, NULL);
>>
>>        return 0;
>>  }
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma

[Andrew Morton]

On Fri, 9 Jan 2009 16:27:07 -0800
Ying Han <yinghan@google.com> wrote:

> friendly ping...

We'll get there.  We're in the merge window now, so I tend to defer
non-serious bugfixes until things are a bit quieter.

> On Thu, Jan 8, 2009 at 6:40 PM, Ying Han <yinghan@google.com> wrote:
> > On Mon, Jan 5, 2009 at 3:39 PM, Ying Han <yinghan@google.com> wrote:
> >> From: Ying Han <yinghan@google.com>
> >>
> >> Fix 32bit binary get 64bit stack vma offset.
> >>
> >> 32bit binary running on 64bit system, the /proc/pid/maps shows for the
> >> vma represents stack get a 64bit adress:
> >> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack]

That changelog hurts my brain.

> >> Signed-off-by:  Ying Han <yinghan@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma

[Ying Han]

On Fri, Jan 9, 2009 at 4:37 PM, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> On Fri, 9 Jan 2009 16:27:07 -0800
> Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>
>> friendly ping...
>
> We'll get there.  We're in the merge window now, so I tend to defer
> non-serious bugfixes until things are a bit quieter.
Thank you Andrew .

>
>> On Thu, Jan 8, 2009 at 6:40 PM, Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>> > On Mon, Jan 5, 2009 at 3:39 PM, Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>> >> From: Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>> >>
>> >> Fix 32bit binary get 64bit stack vma offset.
>> >>
>> >> 32bit binary running on 64bit system, the /proc/pid/maps shows for the
>> >> vma represents stack get a 64bit adress:
>> >> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack]
>
> That changelog hurts my brain.
hm, i will change it for better reading.
>
>> >> Signed-off-by:  Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html