From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B37C433E0 for ; Mon, 25 Jan 2021 21:02:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF88D207B1 for ; Mon, 25 Jan 2021 21:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732353AbhAYVCH (ORCPT ); Mon, 25 Jan 2021 16:02:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732186AbhAYVAa (ORCPT ); Mon, 25 Jan 2021 16:00:30 -0500 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94475C06174A for ; Mon, 25 Jan 2021 12:59:50 -0800 (PST) Received: by mail-qt1-x833.google.com with SMTP id r9so10736491qtp.11 for ; Mon, 25 Jan 2021 12:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JJNWcMOWzRaag3SBCPIuuG3V8rOucOBbI9b8+CXDIO0=; b=mCwNAdUhFxM1x6BU9SHecQkP0XKWNsVDuGrXcNiaFpZnyd2FCzdA9LYEDYGuWgaBOS YGGTa7k2LocdTXi4ioRJXlxxdLVPBMuh1ATzRyKdMpHPageYuJrnqEG7jysVGnjzL2Zo 7q5F/4WtYPab4jsH9mPygYI6ns7SN+s/p0dSdsd/zmiuJcDBY+tDQ5vaAnJfcOo7atco iTDhuUwKelHV3y2ob/NwojMcdHUDDy8OTtptN8ZiHMvDUV8QgZ0qgeltL+BEYRdvezAv uLBypQyjkty1Mcu9eEfGdANFcCW6qnZ5GHKjPg2rdiPh9p9K5NLOE4j7WkNiGtLmJyGX r1rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JJNWcMOWzRaag3SBCPIuuG3V8rOucOBbI9b8+CXDIO0=; b=Dn9xw8abmWCo2I2M9O5ewkIDGPmnxrs7ByRmn0bRwjS0OfuJFKrW9AY5YJWXUquj8C 0YifM3Z1SnabTEVvfNq78Ng5ezuDDRC+jHaWhZdyg41COCBCvlsqhZ3l1ERISSLXHZiq ki83Idw2fIoczN5vaQlZAeKUEaq8i93w3J7OR34NlGEmQygnQkE8c+OITC0skABbPcqm A1e2sNy7TU6wNH/UcQnxYrDHmWyZDgsh5WOqHvkQ8cyd3Y67DYZ4eSkNfo1zbWwVxR/M +yzMSeqyftgIukT3S5ZPai2QeZ6ldExzD05oXvWtyvSLIcUZwaqYN3d4qKmNabbGkLqy ukSQ== X-Gm-Message-State: AOAM5306Km7zgMqMMimt9xzZ1cgf8L4Bos+6/+hLNnnescA/IEIivmLl e9A5rl9bvyqqa/wDW+0wXYU3rg== X-Google-Smtp-Source: ABdhPJwjHGGpnI+Y4Q5fI8hJKvjpozuCCSlNPbHk6TkYeK0ZOSf/+6lz7Yp2jOBeANZUheR7REX2+g== X-Received: by 2002:ac8:4e8b:: with SMTP id 11mr2318597qtp.292.1611608389721; Mon, 25 Jan 2021 12:59:49 -0800 (PST) Received: from ?IPv6:2620:10d:c0a8:11c1::12e0? ([2620:10d:c091:480::1:8a2c]) by smtp.gmail.com with ESMTPSA id r54sm12564072qtr.70.2021.01.25.12.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 12:59:49 -0800 (PST) Subject: Re: [PATCH v7 04/10] btrfs: fix check_data_csum() error message for direct I/O To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: <3a20de6d6ea2a8ebbed0637480f9aa8fff8da19c.1611346706.git.osandov@fb.com> From: Josef Bacik Message-ID: <6233a6de-664d-cdf8-92fd-09ad2b5380a9@toxicpanda.com> Date: Mon, 25 Jan 2021 15:59:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <3a20de6d6ea2a8ebbed0637480f9aa8fff8da19c.1611346706.git.osandov@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 1/22/21 3:46 PM, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 1dae796aabf6 ("btrfs: inode: sink parameter start and len to > check_data_csum()") replaced the start parameter to check_data_csum() > with page_offset(), but page_offset() is not meaningful for direct I/O > pages. Bring back the start parameter. > > Fixes: 265d4ac03fdf ("btrfs: sink parameter start and len to check_data_csum") > Signed-off-by: Omar Sandoval Reviewed-by: Josef Bacik Thanks, Josef