From: Martin Kepplinger <martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iio: doc: fix typo
Date: Sun, 17 May 2015 18:16:06 +0200 [thread overview]
Message-ID: <6D256937-6698-4D42-A786-EC798545EA8F@posteo.de> (raw)
In-Reply-To: <5546737A.9000407-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Am 3. Mai 2015 21:14:02 MESZ, schrieb Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
>On 30/04/15 15:36, Martin Kepplinger wrote:
>> Since we have deviceX, we don't need accelX. This has no users as of
>now, so
>> correcting this is no problem.
>>
>> Signed-off-by: Martin Kepplinger <martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
>The X is certainly misleading. The interface could have a number
>there,
>(if we have a device with multiple parallel accelerometers - unusual,
>but
>not unheard of) but it would be the channel index, not the device index
>and hence should be Y not X.
>
>Or as we don't have any of these anyway, just drop the X and leave it
>as
>an un-indexed accelerometer channel.
>
>Jonathan
There actually is a user, without the index, bma180.c and if it's done correctly there I plan to use it aswell.
I think removing this index would be the right thing now and your scenario may be a bigger change.
martin
>> ---
>>
>> That's really just a question now. If I'm wrong, sorry for the noise.
>>
>> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio
>b/Documentation/ABI/testing/sysfs-bus-iio
>> index 3befcb1..efd1334 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1119,7 +1119,7 @@ Description:
>> This attribute is used to read the amount of quadrature error
>> present in the device at a given time.
>>
>> -What: /sys/.../iio:deviceX/in_accelX_power_mode
>> +What: /sys/.../iio:deviceX/in_accel_power_mode
>> KernelVersion: 3.11
>> Contact: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Description:
>>
prev parent reply other threads:[~2015-05-17 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:36 [PATCH] iio: doc: fix typo Martin Kepplinger
[not found] ` <1430404582-13115-1-git-send-email-martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
2015-05-03 19:14 ` Jonathan Cameron
[not found] ` <5546737A.9000407-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-17 16:16 ` Martin Kepplinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D256937-6698-4D42-A786-EC798545EA8F@posteo.de \
--to=martink-1kbjaw7xf1+zqb+pc5nmwq@public.gmane.org \
--cc=irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox