From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Safonov <0x7f454c46@gmail.com> Subject: Re: [PATCHv4 02/28] timens: Add timens_offsets Date: Fri, 14 Jun 2019 15:32:06 +0100 Message-ID: <6f647a12-fc3c-8be6-a093-f07ff0c9f114@gmail.com> References: <20190612192628.23797-1-dima@arista.com> <20190612192628.23797-3-dima@arista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner , Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Andrei Vagin , Adrian Reber , Andy Lutomirski , Arnd Bergmann , Christian Brauner , Cyrill Gorcunov , "Eric W. Biederman" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jeff Dike , Oleg Nesterov , Pavel Emelyanov , Shuah Khan , Vincenzo Frascino , containers@lists.linux-foundation.org, criu@openvz.org, linux-api@vger.kernel.org, x86@kernel.org List-Id: linux-api@vger.kernel.org On 6/14/19 2:11 PM, Thomas Gleixner wrote: > On Wed, 12 Jun 2019, Dmitry Safonov wrote: > >> From: Andrei Vagin >> >> Introduce offsets for time namespace. They will contain an adjustment >> needed to convert clocks to/from host's. >> >> Allocate one page for each time namespace that will be premapped into >> userspace among vvar pages. >> index 000000000000..7d7cb68ea778 >> --- /dev/null >> +++ b/include/linux/timens_offsets.h >> @@ -0,0 +1,8 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef _LINUX_TIME_OFFSETS_H >> +#define _LINUX_TIME_OFFSETS_H >> + >> +struct timens_offsets { >> +}; > > That empty struct which is nowhere used looks odd. Can you move that to the > patch which actually makes use of it? Sure, makes sense. Thanks, Dmitry