From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2] scsi: ufs: add ioctl interface for query request Date: Wed, 07 Oct 2015 14:37:35 +0200 Message-ID: <7161690.NZs9VETTEZ@wuerfel> References: <1444204457-14935-1-git-send-email-ygardi@codeaurora.org> <14797522.dgtjTj5niW@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Cc: james.bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, santoshsy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-scsi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, gbroner-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, draviv-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Noa Rubens , Raviv Shvili , Vinayak Holikatti , "James E.J. Bottomley" , "open list:ABI/API" List-Id: linux-api@vger.kernel.org On Wednesday 07 October 2015 12:27:54 ygardi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote: > > >> + > >> +/* > >> + * IOCTL opcode for ufs queries has the following opcode after > >> + * SCSI_IOCTL_GET_PCI > >> + */ > >> +#define UFS_IOCTL_QUERY 0x5388 > > > > Use _IOWR() to define that number with the correct argument length > > i'd rather leave it as is, to be compatible with the SCSI_IOCTL > opcodes that are defined in scsi_ioctl.h Do you mean you require this code to work on SunOS? ;-) If not, better use the normal conventions that Linux and BSD have for new ioctls. Note that the 0x53xx ioctl command numbers are also used by include/uapi/linux/cdrom.h, this one would be right in the middle of that. Arnd