From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Borisov Subject: Re: [RFC PATCH v3 03/12] fs: add RWF_ENCODED for reading/writing compressed data Date: Wed, 27 Nov 2019 11:00:15 +0200 Message-ID: <73e9b52f-afed-fa0d-5463-222e41fead56@suse.com> References: <07f9cc1969052e94818fa50019e7589d206d1d18.1574273658.git.osandov@fb.com> <20191126173607.GA657777@vader> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20191126173607.GA657777@vader> Content-Language: en-US Sender: linux-btrfs-owner@vger.kernel.org To: Omar Sandoval Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com List-Id: linux-api@vger.kernel.org On 26.11.19 г. 19:36 ч., Omar Sandoval wrote: > On Tue, Nov 26, 2019 at 03:53:02PM +0200, Nikolay Borisov wrote: >> >> >> On 20.11.19 г. 20:24 ч., Omar Sandoval wrote: >>> From: Omar Sandoval >> >> >> >>> >>> +enum { >>> + ENCODED_IOV_COMPRESSION_NONE, >>> +#define ENCODED_IOV_COMPRESSION_NONE ENCODED_IOV_COMPRESSION_NONE >>> + ENCODED_IOV_COMPRESSION_ZLIB, >>> +#define ENCODED_IOV_COMPRESSION_ZLIB ENCODED_IOV_COMPRESSION_ZLIB >>> + ENCODED_IOV_COMPRESSION_LZO, >>> +#define ENCODED_IOV_COMPRESSION_LZO ENCODED_IOV_COMPRESSION_LZO >>> + ENCODED_IOV_COMPRESSION_ZSTD, >>> +#define ENCODED_IOV_COMPRESSION_ZSTD ENCODED_IOV_COMPRESSION_ZSTD >>> + ENCODED_IOV_COMPRESSION_TYPES = ENCODED_IOV_COMPRESSION_ZSTD, >> >> This looks very dodgy, what am I missing? > > This is a somewhat common trick so that enum values can be checked for > with ifdef/ifndef. See include/uapi/linux.in.h, for example. I cannot seem to have this file on my system (or any .in.h file for that matter in the kernel source dir). >