From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB344F882; Wed, 10 Jan 2024 22:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HNtPaD4k" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d4ca2fd2fbso24861035ad.2; Wed, 10 Jan 2024 14:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704925409; x=1705530209; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=YxsxElpc+jT4mmfFhZPh3DZtom6DY7JYexQS1ckDeao=; b=HNtPaD4kJRUspPNKpAUr2dxoiG8LyYKKlLz247S4HTflSjv54I01jFxnLeaxPplTKq JL5L2ui0g8zSJfFie9jlZ8/n/LODPmODsrKOkWvBPWOTBlJlvcRBKIoYnSSJIDS5XbKz e0MufS6DsxAexT8E7O6UgDpuHBoiarsdaTQjZp9YTyEQKIrpMTCZWPYIv3Ns4oKJ606I XQ7eP7eLQAJCHSjByllqx8D0qj1bUXy61yxVO/Zhiaxxaud42LX0RW/iECrAioeLad1F quq2NYU30qnuhN5yCjl3avY/1G0fY5iPsnemHGKzeRB+O+YrYu4+UakLYFS38GVxS5ri FtuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704925409; x=1705530209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YxsxElpc+jT4mmfFhZPh3DZtom6DY7JYexQS1ckDeao=; b=TkKzWy2hqWN7eP/jxQGEk5nnugI9YSV+Kd00lBRS6rjSNDyevCALOHNanZvgyGjcxt a8PV9XWKzlQUqtKOI0KkokdghfHxuciCbSemIMz4wC4GCH/2f66eo6PuwY7ThNcBjUO2 /GDmNVMINCT754PRR1ASd4h4SeXIHTZF29SX0F1C685oqh+Ud9kIKMjcy28Mto7OPWYf DAan5cbS9dRlN9KxTBTVvClPgdQOS2YbycFYwSQ5l5lvbOg/z9EmEAomVLkRPWPNcCtp PVHw+9gRvkNbyJLOuqfWjtaoowJeAy9lfdf9btU1nBaEnauKpUOvb9ybFMxCjuiNZu5w 6C6Q== X-Gm-Message-State: AOJu0YwaLBJU6uW1TOsuH0ppW4GAYtz6cgcOK5Zp0rJy55diBcV9Ls0U IfpZp2dRLaGPv1tlOwFLdt4= X-Google-Smtp-Source: AGHT+IGeLGDDAGN9Ml97cgT8MOww4VOvyzegLjaWhxhlroPbTTKHlKjmxi9wcV5Ku03hRVlwCCLv3w== X-Received: by 2002:a17:90b:4d91:b0:28b:d90c:c724 with SMTP id oj17-20020a17090b4d9100b0028bd90cc724mr180672pjb.54.1704925408886; Wed, 10 Jan 2024 14:23:28 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id gk9-20020a17090b118900b0028d19ddb1afsm2095854pjb.33.2024.01.10.14.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 14:23:28 -0800 (PST) Sender: Guenter Roeck Date: Wed, 10 Jan 2024 14:23:26 -0800 From: Guenter Roeck To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, Karel Zak , Ian Kent , David Howells , Linus Torvalds , Al Viro , Christian Brauner , Amir Goldstein , Matthew House , Florian Weimer , Arnd Bergmann Subject: Re: [PATCH v4 5/6] add listmount(2) syscall Message-ID: <75b87a85-7d2c-4078-91e3-024ea36cfb42@roeck-us.net> References: <20231025140205.3586473-1-mszeredi@redhat.com> <20231025140205.3586473-6-mszeredi@redhat.com> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025140205.3586473-6-mszeredi@redhat.com> Hi, On Wed, Oct 25, 2023 at 04:02:03PM +0200, Miklos Szeredi wrote: > Add way to query the children of a particular mount. This is a more > flexible way to iterate the mount tree than having to parse the complete > /proc/self/mountinfo. > > Allow listing either > > - immediate child mounts only, or > > - recursively all descendant mounts (depth first). > > Lookup the mount by the new 64bit mount ID. If a mount needs to be queried > based on path, then statx(2) can be used to first query the mount ID > belonging to the path. > > Return an array of new (64bit) mount ID's. Without privileges only mounts > are listed which are reachable from the task's root. > > Signed-off-by: Miklos Szeredi with this patch in the tree, all sh4 builds fail with ICE. during RTL pass: final In file included from fs/namespace.c:11: fs/namespace.c: In function '__se_sys_listmount': include/linux/syscalls.h:258:9: internal compiler error: in change_address_1, at emit-rtl.c:2275 I tested with gcc 8.2, 11.3, 11.4, and 12.3. The compiler version does not make a difference. Has anyone else seen the same problem ? If so, any idea what to do about it ? Thanks, Guenter