From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E84B6C433DF for ; Mon, 24 Aug 2020 20:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3D07206BE for ; Mon, 24 Aug 2020 20:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="E5NfFSK4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727011AbgHXUa5 (ORCPT ); Mon, 24 Aug 2020 16:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgHXUaz (ORCPT ); Mon, 24 Aug 2020 16:30:55 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51441C061574 for ; Mon, 24 Aug 2020 13:30:55 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id s15so4447466qvv.7 for ; Mon, 24 Aug 2020 13:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7F5yeAJVZaUbpuBUqNk5OdFniuSN7bl4J4c2+t3bWAk=; b=E5NfFSK4/q1Q0nTU/eGzgCX/V23x9LAfwDIy6XlB91z58sGURuizUYs9Wh/gsJkULw sImf0WVU1SrSFBDQVpZMyVtjALj09jhkaE2bOeyzQo0PEpZvuoeGewoPSO77SZDJdPm2 TK8083D+pbtxlytylUD40a67pKCsSGr66yAEszF3qoHfiFs/IIsl1JGAIMZ7PVosS5T4 fEUY8fR/OCOFncLLdCZV27ebJiDRFdYE7bWg5TUso76iOQGiiTHyjD12cDVJ+7cGMizi Yxxnwb6TSpPXz0P5Xd9E78AsZYZHSgWLFLXC2MHRZ9RRnM2Zb37OLJjgfvsM1QNXgppy QmBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7F5yeAJVZaUbpuBUqNk5OdFniuSN7bl4J4c2+t3bWAk=; b=sFpJVLgyP4+bvewNcxxkJ83RhJ+vdjFWHnHchy39O7gHc0Qks2+Mn+A4VxB6jU2yK2 cDWG/65nuAgNWYiNw8kWfkxBldfcPNUjxS6YnKye3NECb+SX++KEhBh5KvLMoT380q9z GGXUJDWkLsMSiGwD/7bXqc8V6Lgz0j5i4nWXBDw0u/hJ25J9BpXkSIlcQAZID8Vlbh5g Xq9eYM5P4lsXo2AENHXs1ioDEu9vqnt5L9te8oou29gHG0P71zCXi/HhQ6I1JGB37tw7 AmxgUoTNzp25+B+1yg5bqyEvsNP3bi8mKCZFgx9GYuslHDMFsKlfMecihCuW8UsSxbkZ xmIA== X-Gm-Message-State: AOAM530sKriWdfyFZRG+RAZMEQOI/ZEx/NQQF6NfHkc8qhMaRrsn6MKi EggHrREztp3g1/OzAm5VJM1jzw== X-Google-Smtp-Source: ABdhPJxY5TAoYucdNMqxjw7Il+TKuQJrUqIBrBsaY+3xiLC2oNlMq3wdZaJPqa2wUyYhWkqXbr3Gbw== X-Received: by 2002:a05:6214:542:: with SMTP id ci2mr6189227qvb.7.1598301054399; Mon, 24 Aug 2020 13:30:54 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id m30sm12516959qtm.46.2020.08.24.13.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 13:30:53 -0700 (PDT) Subject: Re: [PATCH v5 9/9] btrfs: implement RWF_ENCODED writes To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: <07a61c2f9a07497c165c05106dd0f9ced5bbc4fc.1597993855.git.osandov@osandov.com> From: Josef Bacik Message-ID: <83d564d8-234c-a2b5-e261-80ea3b96f6d1@toxicpanda.com> Date: Mon, 24 Aug 2020 16:30:52 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <07a61c2f9a07497c165c05106dd0f9ced5bbc4fc.1597993855.git.osandov@osandov.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 8/21/20 3:38 AM, Omar Sandoval wrote: > From: Omar Sandoval > > The implementation resembles direct I/O: we have to flush any ordered > extents, invalidate the page cache, and do the io tree/delalloc/extent > map/ordered extent dance. From there, we can reuse the compression code > with a minor modification to distinguish the write from writeback. This > also creates inline extents when possible. > > Now that read and write are implemented, this also sets the > FMODE_ENCODED_IO flag in btrfs_file_open(). > > Signed-off-by: Omar Sandoval > --- > fs/btrfs/compression.c | 7 +- > fs/btrfs/compression.h | 6 +- > fs/btrfs/ctree.h | 2 + > fs/btrfs/file.c | 40 +++++-- > fs/btrfs/inode.c | 246 +++++++++++++++++++++++++++++++++++++++- > fs/btrfs/ordered-data.c | 12 +- > fs/btrfs/ordered-data.h | 2 + > 7 files changed, 298 insertions(+), 17 deletions(-) > > + > + ret = btrfs_alloc_data_chunk_ondemand(BTRFS_I(inode), disk_num_bytes); > + if (ret) > + goto out_unlock; > + ret = btrfs_qgroup_reserve_data(BTRFS_I(inode), &data_reserved, start, > + num_bytes); > + if (ret) > + goto out_free_data_space; > + ret = btrfs_delalloc_reserve_metadata(BTRFS_I(inode), num_bytes, > + disk_num_bytes); > + if (ret) > + goto out_qgroup_free_data; This can just be btrfs_delalloc_reserve_space() and that way the error handling is much cleaner. > + > +out_free_reserved: > + btrfs_dec_block_group_reservations(fs_info, ins.objectid); > + btrfs_free_reserved_extent(fs_info, ins.objectid, ins.offset, 1); > +out_delalloc_release: > + btrfs_delalloc_release_extents(BTRFS_I(inode), num_bytes); > + btrfs_delalloc_release_metadata(BTRFS_I(inode), disk_num_bytes, > + ret < 0); Likewise this can all just be btrfs_free_reserved_data_space(). Thanks, Josef