* Re: [PATCH v4 0/2] Syscall User Redirection
[not found] <20200716193141.4068476-1-krisman@collabora.com>
@ 2020-07-16 20:04 ` Kees Cook
2020-07-16 20:22 ` Christian Brauner
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2020-07-16 20:04 UTC (permalink / raw)
To: Gabriel Krisman Bertazi, Andy Lutomirski, Matthew Wilcox
Cc: tglx, linux-kernel, kernel, gofmanp, linux-api, x86,
linux-kselftest, shuah
On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
> This is v4 of Syscall User Redirection. The implementation itself is
> not modified from v3, it only applies the latest round of reviews to the
> selftests.
>
> __NR_syscalls is not really exported in header files other than
> asm-generic for every architecture, so it felt safer to optionally
> expose it with a fallback to a high value.
>
> Also, I didn't expose tests for PR_GET as that is not currently
> implemented. If possible, I'd have it supported by a future patchset,
> since it is not immediately necessary to support this feature.
Thanks! That all looks good to me.
> Finally, one question: Which tree would this go through?
I haven't heard from several other x86 maintainers yet (which is where
I would normally expect this series to land), but I would be comfortable
taking this through my seccomp tree if I got Acks/Reviews at least from
Andy and Matthew.
Andy, Matthew, what do you think of this?
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] Syscall User Redirection
2020-07-16 20:04 ` [PATCH v4 0/2] Syscall User Redirection Kees Cook
@ 2020-07-16 20:22 ` Christian Brauner
2020-07-16 20:25 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Christian Brauner @ 2020-07-16 20:22 UTC (permalink / raw)
To: Kees Cook
Cc: Gabriel Krisman Bertazi, Andy Lutomirski, Matthew Wilcox, tglx,
linux-kernel, kernel, gofmanp, linux-api, x86, linux-kselftest,
shuah, jannh
On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
> On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
> > This is v4 of Syscall User Redirection. The implementation itself is
> > not modified from v3, it only applies the latest round of reviews to the
> > selftests.
> >
> > __NR_syscalls is not really exported in header files other than
> > asm-generic for every architecture, so it felt safer to optionally
> > expose it with a fallback to a high value.
> >
> > Also, I didn't expose tests for PR_GET as that is not currently
> > implemented. If possible, I'd have it supported by a future patchset,
> > since it is not immediately necessary to support this feature.
>
> Thanks! That all looks good to me.
Don't have any problem with this but did this ever get exposure on
linux-api? This is the first time I see this pop up.
Christian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] Syscall User Redirection
2020-07-16 20:22 ` Christian Brauner
@ 2020-07-16 20:25 ` Kees Cook
2020-07-16 20:29 ` Christian Brauner
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2020-07-16 20:25 UTC (permalink / raw)
To: Christian Brauner
Cc: Gabriel Krisman Bertazi, Andy Lutomirski, Matthew Wilcox, tglx,
linux-kernel, kernel, gofmanp, linux-api, x86, linux-kselftest,
shuah, jannh
On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote:
> On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
> > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
> > > This is v4 of Syscall User Redirection. The implementation itself is
> > > not modified from v3, it only applies the latest round of reviews to the
> > > selftests.
> > >
> > > __NR_syscalls is not really exported in header files other than
> > > asm-generic for every architecture, so it felt safer to optionally
> > > expose it with a fallback to a high value.
> > >
> > > Also, I didn't expose tests for PR_GET as that is not currently
> > > implemented. If possible, I'd have it supported by a future patchset,
> > > since it is not immediately necessary to support this feature.
> >
> > Thanks! That all looks good to me.
>
> Don't have any problem with this but did this ever get exposure on
> linux-api? This is the first time I see this pop up.
I thought I'd added it to CC in the past, but that might have been other
recent unrelated threads. Does this need a full repost there too, you
think?
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] Syscall User Redirection
2020-07-16 20:25 ` Kees Cook
@ 2020-07-16 20:29 ` Christian Brauner
2020-07-16 20:30 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 6+ messages in thread
From: Christian Brauner @ 2020-07-16 20:29 UTC (permalink / raw)
To: Kees Cook
Cc: Gabriel Krisman Bertazi, Andy Lutomirski, Matthew Wilcox, tglx,
linux-kernel, kernel, gofmanp, linux-api, x86, linux-kselftest,
shuah, jannh
On Thu, Jul 16, 2020 at 01:25:43PM -0700, Kees Cook wrote:
> On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote:
> > On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
> > > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
> > > > This is v4 of Syscall User Redirection. The implementation itself is
> > > > not modified from v3, it only applies the latest round of reviews to the
> > > > selftests.
> > > >
> > > > __NR_syscalls is not really exported in header files other than
> > > > asm-generic for every architecture, so it felt safer to optionally
> > > > expose it with a fallback to a high value.
> > > >
> > > > Also, I didn't expose tests for PR_GET as that is not currently
> > > > implemented. If possible, I'd have it supported by a future patchset,
> > > > since it is not immediately necessary to support this feature.
> > >
> > > Thanks! That all looks good to me.
> >
> > Don't have any problem with this but did this ever get exposure on
> > linux-api? This is the first time I see this pop up.
>
> I thought I'd added it to CC in the past, but that might have been other
> recent unrelated threads. Does this need a full repost there too, you
> think?
Nah, wasn't my intention to force a repost. Seems that several people
have looked this over. :) Just curious why it didn't get to linux-api
and we know quite some people who only do look at linux-api (for sanity). :)
Christian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] Syscall User Redirection
2020-07-16 20:29 ` Christian Brauner
@ 2020-07-16 20:30 ` Gabriel Krisman Bertazi
2020-07-16 21:06 ` Carlos O'Donell
0 siblings, 1 reply; 6+ messages in thread
From: Gabriel Krisman Bertazi @ 2020-07-16 20:30 UTC (permalink / raw)
To: Christian Brauner
Cc: Kees Cook, Andy Lutomirski, Matthew Wilcox, tglx, linux-kernel,
kernel, gofmanp, linux-api, x86, linux-kselftest, shuah, jannh
Christian Brauner <christian.brauner@ubuntu.com> writes:
> On Thu, Jul 16, 2020 at 01:25:43PM -0700, Kees Cook wrote:
>> On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote:
>> > On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
>> > > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
>> > > > This is v4 of Syscall User Redirection. The implementation itself is
>> > > > not modified from v3, it only applies the latest round of reviews to the
>> > > > selftests.
>> > > >
>> > > > __NR_syscalls is not really exported in header files other than
>> > > > asm-generic for every architecture, so it felt safer to optionally
>> > > > expose it with a fallback to a high value.
>> > > >
>> > > > Also, I didn't expose tests for PR_GET as that is not currently
>> > > > implemented. If possible, I'd have it supported by a future patchset,
>> > > > since it is not immediately necessary to support this feature.
>> > >
>> > > Thanks! That all looks good to me.
>> >
>> > Don't have any problem with this but did this ever get exposure on
>> > linux-api? This is the first time I see this pop up.
>>
>> I thought I'd added it to CC in the past, but that might have been other
>> recent unrelated threads. Does this need a full repost there too, you
>> think?
>
> Nah, wasn't my intention to force a repost. Seems that several people
> have looked this over. :) Just curious why it didn't get to linux-api
> and we know quite some people who only do look at linux-api (for sanity). :)
That's my mistake. I didn't think about it when submitting :(
If this get re-spinned again I will make sure to CC linux-api.
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 0/2] Syscall User Redirection
2020-07-16 20:30 ` Gabriel Krisman Bertazi
@ 2020-07-16 21:06 ` Carlos O'Donell
0 siblings, 0 replies; 6+ messages in thread
From: Carlos O'Donell @ 2020-07-16 21:06 UTC (permalink / raw)
To: Gabriel Krisman Bertazi, Christian Brauner
Cc: Kees Cook, Andy Lutomirski, Matthew Wilcox, tglx, linux-kernel,
kernel, gofmanp, linux-api, x86, linux-kselftest, shuah, jannh
On 7/16/20 4:30 PM, Gabriel Krisman Bertazi wrote:
> Christian Brauner <christian.brauner@ubuntu.com> writes:
>
>> On Thu, Jul 16, 2020 at 01:25:43PM -0700, Kees Cook wrote:
>>> On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote:
>>>> On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote:
>>>>> On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote:
>>>>>> This is v4 of Syscall User Redirection. The implementation itself is
>>>>>> not modified from v3, it only applies the latest round of reviews to the
>>>>>> selftests.
>>>>>>
>>>>>> __NR_syscalls is not really exported in header files other than
>>>>>> asm-generic for every architecture, so it felt safer to optionally
>>>>>> expose it with a fallback to a high value.
>>>>>>
>>>>>> Also, I didn't expose tests for PR_GET as that is not currently
>>>>>> implemented. If possible, I'd have it supported by a future patchset,
>>>>>> since it is not immediately necessary to support this feature.
>>>>>
>>>>> Thanks! That all looks good to me.
>>>>
>>>> Don't have any problem with this but did this ever get exposure on
>>>> linux-api? This is the first time I see this pop up.
>>>
>>> I thought I'd added it to CC in the past, but that might have been other
>>> recent unrelated threads. Does this need a full repost there too, you
>>> think?
>>
>> Nah, wasn't my intention to force a repost. Seems that several people
>> have looked this over. :) Just curious why it didn't get to linux-api
>> and we know quite some people who only do look at linux-api (for sanity). :)
>
> That's my mistake. I didn't think about it when submitting :(
>
> If this get re-spinned again I will make sure to CC linux-api.
Thank you! It helps C library implementors stay up to date and comment
on changes that impact userspace ABIs and APIs. This patch set was new
to me. Interesting new feature.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-16 21:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200716193141.4068476-1-krisman@collabora.com>
2020-07-16 20:04 ` [PATCH v4 0/2] Syscall User Redirection Kees Cook
2020-07-16 20:22 ` Christian Brauner
2020-07-16 20:25 ` Kees Cook
2020-07-16 20:29 ` Christian Brauner
2020-07-16 20:30 ` Gabriel Krisman Bertazi
2020-07-16 21:06 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).