From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F923C2BA2B for ; Thu, 16 Apr 2020 20:36:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73534206A2 for ; Thu, 16 Apr 2020 20:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729003AbgDPUgW (ORCPT ); Thu, 16 Apr 2020 16:36:22 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:40974 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgDPUgV (ORCPT ); Thu, 16 Apr 2020 16:36:21 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jPBF9-0003Wf-Lk; Thu, 16 Apr 2020 14:36:15 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jPBF8-0008Kz-Fm; Thu, 16 Apr 2020 14:36:15 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Paul Moore Cc: Richard Guy Briggs , nhorman@tuxdriver.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , dhowells@redhat.com, linux-audit@redhat.com, netfilter-devel@vger.kernel.org, simo@redhat.com, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Paris , mpatel@redhat.com, Serge Hallyn References: <20200318215550.es4stkjwnefrfen2@madcap2.tricolour.ca> <20200319220249.jyr6xmwvflya5mks@madcap2.tricolour.ca> <20200324210152.5uydf3zqi3dwshfu@madcap2.tricolour.ca> <20200330134705.jlrkoiqpgjh3rvoh@madcap2.tricolour.ca> <20200330162156.mzh2tsnovngudlx2@madcap2.tricolour.ca> <20200330174937.xalrsiev7q3yxsx2@madcap2.tricolour.ca> Date: Thu, 16 Apr 2020 15:33:13 -0500 In-Reply-To: (Paul Moore's message of "Mon, 30 Mar 2020 15:55:36 -0400") Message-ID: <871ronf9x2.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jPBF8-0008Kz-Fm;;;mid=<871ronf9x2.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18QCbICEec/DdkpMxCQSiOIlOx7aNlCCNU= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH ghak90 V8 07/16] audit: add contid support for signalling the audit daemon X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org Paul Moore writes: > On Mon, Mar 30, 2020 at 1:49 PM Richard Guy Briggs wrote: >> On 2020-03-30 13:34, Paul Moore wrote: >> > On Mon, Mar 30, 2020 at 12:22 PM Richard Guy Briggs wrote: >> > > On 2020-03-30 10:26, Paul Moore wrote: >> > > > On Mon, Mar 30, 2020 at 9:47 AM Richard Guy Briggs wrote: >> > > > > On 2020-03-28 23:11, Paul Moore wrote: >> > > > > > On Tue, Mar 24, 2020 at 5:02 PM Richard Guy Briggs wrote: >> > > > > > > On 2020-03-23 20:16, Paul Moore wrote: >> > > > > > > > On Thu, Mar 19, 2020 at 6:03 PM Richard Guy Briggs wrote: >> > > > > > > > > On 2020-03-18 18:06, Paul Moore wrote: > > ... > >> > > Well, every time a record gets generated, *any* record gets generated, >> > > we'll need to check for which audit daemons this record is in scope and >> > > generate a different one for each depending on the content and whether >> > > or not the content is influenced by the scope. >> > >> > That's the problem right there - we don't want to have to generate a >> > unique record for *each* auditd on *every* record. That is a recipe >> > for disaster. >> > >> > Solving this for all of the known audit records is not something we >> > need to worry about in depth at the moment (although giving it some >> > casual thought is not a bad thing), but solving this for the audit >> > container ID information *is* something we need to worry about right >> > now. >> >> If you think that a different nested contid value string per daemon is >> not acceptable, then we are back to issuing a record that has only *one* >> contid listed without any nesting information. This brings us back to >> the original problem of keeping *all* audit log history since the boot >> of the machine to be able to track the nesting of any particular contid. > > I'm not ruling anything out, except for the "let's just completely > regenerate every record for each auditd instance". Paul I am a bit confused about what you are referring to when you say regenerate every record. Are you saying that you don't want to repeat the sequence: audit_log_start(...); audit_log_format(...); audit_log_end(...); for every nested audit daemon? Or are you saying that you would like to literraly want to send the same skb to each of the nested audit daemons? Or are you thinking of something else? Eric