From: "Huang\, Ying" <ying.huang@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
Rafael Aquini <aquini@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, "Mel Gorman" <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>, <linux-api@vger.kernel.org>
Subject: Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING
Date: Tue, 01 Dec 2020 08:27:43 +0800 [thread overview]
Message-ID: <87a6uyqsjk.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <a5d4c16b-74d7-403f-5f1c-8a1e8cbe4efb@intel.com> (Dave Hansen's message of "Mon, 30 Nov 2020 09:48:56 -0800")
Dave Hansen <dave.hansen@intel.com> writes:
> On 11/25/20 9:32 PM, Huang Ying wrote:
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,11 @@ A nonempty
>> .I nodemask
>> specifies node IDs that are relative to the set of
>> node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +Enable the Linux kernel NUMA balancing for the task if it is supported
>> +by kernel. If the flag isn't supported by Linux kernel, return -1 and
>> +errno is set to EINVAL.
>
> The one thing I learned about manpage CodingStyle is that new sentences
> go on new lines. I think this needs to be:
>
> .TP
> .BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> Enable the Linux kernel NUMA balancing for the task if it is supported
> by kernel.
> If the flag isn't supported by Linux kernel, return -1 and errno is set
> to EINVAL.
Thanks a lot for your information! I will revise this in the next version.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2020-12-01 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 5:32 [PATCH -V6 0/3] autonuma: Migrate on fault among multiple bound nodes Huang Ying
2020-11-26 5:32 ` [PATCH -V6 1/3] numa balancing: " Huang Ying
2020-11-26 5:32 ` [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING Huang Ying
2020-11-30 17:48 ` Dave Hansen
2020-12-01 0:27 ` Huang, Ying [this message]
2020-11-26 5:32 ` [PATCH -V6 3/3] NOT kernel/numactl: Support to enable Linux kernel NUMA balancing Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6uyqsjk.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).