From: Florian Weimer <fweimer@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, dev@opencontainers.org,
corbet@lwn.net, Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] syscalls: Document OCI seccomp filter interactions & workaround
Date: Tue, 24 Nov 2020 19:09:44 +0100 [thread overview]
Message-ID: <87im9uzkwn.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <dcffcbacbc75086582ea3f073c9e6a981a6dd27f.camel@klomp.org> (Mark Wielaard's message of "Tue, 24 Nov 2020 15:08:05 +0100")
* Mark Wielaard:
> For valgrind the issue is statx which we try to use before falling back
> to stat64, fstatat or stat (depending on architecture, not all define
> all of these). The problem with these fallbacks is that under some
> containers (libseccomp versions) they might return EPERM instead of
> ENOSYS. This causes really obscure errors that are really hard to
> diagnose.
The probing sequence I proposed should also work for statx. 8-p
> Don't you have the same issue with glibc for those architectures that
> don't have fstatat or 32bit arches that need 64-bit time_t? And if so,
> how are you working around containers possibly returning EPERM instead
> of ENOSYS?
That's a good point. I don't think many people run 32-bit containers in
the cloud. The Y2038 changes in glibc impact 64-bit ports a little, but
mostly on the fringes (e.g., clock_nanosleep vs nanosleep).
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2020-11-24 18:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 12:08 [PATCH] syscalls: Document OCI seccomp filter interactions & workaround Florian Weimer
2020-11-24 12:26 ` Christian Brauner
2020-11-24 12:54 ` Florian Weimer
2020-11-24 14:08 ` Mark Wielaard
2020-11-24 16:45 ` Christoph Hellwig
2020-11-24 17:06 ` Jann Horn
2020-11-24 17:15 ` Greg KH
2020-11-24 17:21 ` Christian Brauner
2020-11-24 17:30 ` Jann Horn
2020-11-24 17:44 ` Greg KH
2020-11-24 17:47 ` Jann Horn
2020-11-24 18:17 ` Florian Weimer
2020-11-24 18:02 ` Florian Weimer
2020-11-24 18:09 ` Florian Weimer [this message]
2020-11-24 12:58 ` Aleksa Sarai
2020-11-24 13:05 ` Florian Weimer
2020-11-24 13:37 ` Christoph Hellwig
2020-11-24 14:08 ` Florian Weimer
2020-11-24 16:46 ` Christoph Hellwig
2020-11-24 16:52 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im9uzkwn.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=christian.brauner@ubuntu.com \
--cc=corbet@lwn.net \
--cc=dev@opencontainers.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).