From: Florian Weimer <fw@deneb.enyo.de>
To: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Andreas Dilger <adilger@dilger.ca>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: statx(2) API and documentation
Date: Thu, 18 Oct 2018 09:49:28 +0200 [thread overview]
Message-ID: <87in1zy9rr.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20181018074101.GJ23493@quack2.suse.cz> (Jan Kara's message of "Thu, 18 Oct 2018 09:41:01 +0200")
* Jan Kara:
> On Thu 18-10-18 01:15:13, Amir Goldstein wrote:
>> FYI, I identified a similar anti-pattern in fanotify UAPI when I wanted to
>> add new flags and did not want to change the UAPI _ALL_ constants.
>> This is how we plan to solve it:
>> https://github.com/amir73il/linux/commit/8c2b1acadb88ee4505ccc8bfdc665863111fb4cc
>
> Yeah, after fanotify experience I find foo_ALL constants useless if not
> dangerous for userspace. Kernel internal constants like this are IMO
> useful.
There are also various *_MAX constants which are increased regularly.
Some of them are part of the UAPI headers (INET_DIAG_MAX appears to be
a relevant example), some are no longer in UAPI, but still in custom
glibc headers (AF_MAX/PF_MAX). These appear to be equally useless.
next prev parent reply other threads:[~2018-10-18 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:24 statx(2) API and documentation Miklos Szeredi
2018-10-17 18:45 ` Andreas Dilger
2018-10-17 19:04 ` Miklos Szeredi
2018-10-17 20:22 ` Andreas Dilger
2018-10-17 22:22 ` Florian Weimer
2018-10-18 7:37 ` Miklos Szeredi
2018-10-18 7:39 ` Florian Weimer
2018-10-18 7:42 ` Miklos Szeredi
2018-10-18 7:23 ` Miklos Szeredi
2018-10-17 22:15 ` Amir Goldstein
2018-10-18 7:41 ` Jan Kara
2018-10-18 7:49 ` Florian Weimer [this message]
2018-10-18 16:04 ` David Howells
2018-10-18 20:21 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in1zy9rr.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).