From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>, axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net,
andrealmeid@igalia.com, Andrew Morton <akpm@linux-foundation.org>,
urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com,
Arnd Bergmann <arnd@arndb.de>,
linux-api@vger.kernel.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, malteskarupke@web.de
Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags
Date: Mon, 31 Jul 2023 19:42:11 +0200 [thread overview]
Message-ID: <87mszcm0zw.ffs@tglx> (raw)
In-Reply-To: <87edkonjrk.ffs@tglx>
On Mon, Jul 31 2023 at 18:11, Thomas Gleixner wrote:
> On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote:
>> +#define FUTEX2_8 0x00
>> +#define FUTEX2_16 0x01
>> #define FUTEX2_32 0x02
>> - /* 0x04 */
>> +#define FUTEX2_64 0x03
>> +#define FUTEX2_NUMA 0x04
>> /* 0x08 */
>> /* 0x10 */
>> /* 0x20 */
>> --- a/kernel/futex/syscalls.c
>> +++ b/kernel/futex/syscalls.c
>> @@ -183,7 +183,7 @@ SYSCALL_DEFINE6(futex, u32 __user *, uad
>> return do_futex(uaddr, op, val, tp, uaddr2, (unsigned long)utime, val3);
>> }
>>
>> -#define FUTEX2_MASK (FUTEX2_32 | FUTEX2_PRIVATE)
>> +#define FUTEX2_MASK (FUTEX2_64 | FUTEX2_PRIVATE)
>>
>> /**
>> * futex_parse_waitv - Parse a waitv array from userspace
>> @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute
>> if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved)
>> return -EINVAL;
>
> With the above aux.flags with FUTEX2_32 set will result in -EINVAL. I
> don't think that's intentional.
Aargh. This is really nasty to make FUTEX2_64 0x3 and abuse it to test
the flags for validity. Intuitive and obvious is something else.
next prev parent reply other threads:[~2023-07-31 17:42 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:22 [PATCH v1 00/14] futex: More futex2 bits Peter Zijlstra
2023-07-21 10:22 ` [PATCH v1 01/14] futex: Clarify FUTEX2 flags Peter Zijlstra
2023-07-31 16:08 ` Thomas Gleixner
2023-07-21 10:22 ` [PATCH v1 02/14] futex: Extend the " Peter Zijlstra
2023-07-21 15:47 ` Arnd Bergmann
2023-07-21 18:52 ` Peter Zijlstra
2023-07-31 16:11 ` Thomas Gleixner
2023-07-31 16:25 ` Peter Zijlstra
2023-07-31 17:16 ` Thomas Gleixner
2023-07-31 17:35 ` Peter Zijlstra
2023-07-31 20:52 ` Thomas Gleixner
2023-07-31 17:42 ` Thomas Gleixner [this message]
2023-07-31 19:20 ` Peter Zijlstra
2023-07-31 21:14 ` Thomas Gleixner
2023-07-31 21:33 ` Peter Zijlstra
2023-07-31 22:43 ` Thomas Gleixner
2023-07-31 22:59 ` Peter Zijlstra
2023-08-01 8:49 ` Thomas Gleixner
2023-08-01 6:02 ` Arnd Bergmann
2023-07-21 10:22 ` [PATCH v1 03/14] futex: Flag conversion Peter Zijlstra
2023-07-31 16:21 ` Thomas Gleixner
2023-07-31 16:26 ` Peter Zijlstra
2023-07-21 10:22 ` [PATCH v1 04/14] futex: Validate futex value against futex size Peter Zijlstra
2023-07-31 17:12 ` Thomas Gleixner
2023-07-21 10:22 ` [PATCH v1 05/14] futex: Add sys_futex_wake() Peter Zijlstra
2023-07-21 15:41 ` Arnd Bergmann
2023-07-21 18:54 ` Peter Zijlstra
2023-07-21 21:23 ` Arnd Bergmann
2023-07-25 7:22 ` Geert Uytterhoeven
2023-07-21 10:22 ` [PATCH v1 06/14] futex: Add sys_futex_wait() Peter Zijlstra
2023-07-25 7:22 ` Geert Uytterhoeven
2023-07-31 16:35 ` Thomas Gleixner
2023-07-21 10:22 ` [PATCH v1 07/14] futex: Propagate flags into get_futex_key() Peter Zijlstra
2023-07-31 16:36 ` Thomas Gleixner
2023-07-21 10:22 ` [PATCH v1 08/14] futex: Add flags2 argument to futex_requeue() Peter Zijlstra
2023-07-31 16:43 ` Thomas Gleixner
2023-07-21 10:22 ` [PATCH v1 09/14] futex: Add sys_futex_requeue() Peter Zijlstra
2023-07-25 7:23 ` Geert Uytterhoeven
2023-07-31 17:19 ` Thomas Gleixner
2023-07-31 17:38 ` Peter Zijlstra
2023-07-21 10:22 ` [PATCH v1 10/14] mm: Add vmalloc_huge_node() Peter Zijlstra
2023-07-24 13:46 ` Christoph Hellwig
2023-07-21 10:22 ` [PATCH v1 11/14] futex: Implement FUTEX2_NUMA Peter Zijlstra
2023-07-21 12:16 ` Peter Zijlstra
2023-07-31 17:36 ` Thomas Gleixner
2023-07-31 18:03 ` Peter Zijlstra
2023-07-31 21:26 ` Thomas Gleixner
2024-06-12 17:07 ` Christoph Lameter (Ampere)
2024-06-12 17:23 ` Christoph Lameter (Ampere)
2024-06-12 17:44 ` Peter Zijlstra
2024-06-18 16:53 ` Christoph Lameter (Ampere)
2024-10-25 8:58 ` Peter Zijlstra
2024-10-25 19:36 ` Christoph Lameter (Ampere)
2024-10-26 7:21 ` Peter Zijlstra
2024-10-28 22:32 ` Christoph Lameter (Ampere)
2023-07-21 10:22 ` [PATCH v1 12/14] futex: Propagate flags into futex_get_value_locked() Peter Zijlstra
2023-07-21 10:22 ` [PATCH v1 13/14] futex: Enable FUTEX2_{8,16} Peter Zijlstra
2023-07-21 10:22 ` [PATCH v1 14/14] futex,selftests: Extend the futex selftests Peter Zijlstra
2023-07-21 14:42 ` [PATCH v1 00/14] futex: More futex2 bits Jens Axboe
2023-07-21 15:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mszcm0zw.ffs@tglx \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=malteskarupke@web.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).