From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold Date: Wed, 25 Sep 2019 20:09:26 -0500 Message-ID: <87sgoj2795.fsf@x220.int.ebiederm.org> References: <66b16acf2953fc033abc9641b9cf43d23e75a8e9.1568990048.git.luto@kernel.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Jann Horn's message of "Tue, 24 Sep 2019 22:30:55 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Jann Horn Cc: Andy Lutomirski , Theodore Tso , LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man List-Id: linux-api@vger.kernel.org Jann Horn writes: > On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski wrote: >> It has no effect any more, so remove it. We can revert this if >> there is some user code that expects to be able to set this sysctl. >> >> Signed-off-by: Andy Lutomirski >> --- >> drivers/char/random.c | 18 +----------------- >> 1 file changed, 1 insertion(+), 17 deletions(-) >> >> diff --git a/drivers/char/random.c b/drivers/char/random.c > [...] >> - { >> - .procname = "read_wakeup_threshold", > > There's a line in bin_random_table in kernel/sysctl_binary.c that > refers to this sysctl, that should probably also be deleted? I think it should be safe to leave in kernel/sysctl_binary.c This reminds me. I think we may finally be at a point where we can remove practically all of kernel/sysctl_binary.c I need to double check but last I looked no distro enables COINFIG_SYSCTL_SYSCALL anymore. Ubunutu was the last distro I know of that enabled it, and I think it has been a year or more since Ubuntu disabled CONFIG_SYSCTL_SYSCALL. Eric