From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Shishkin Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices Date: Thu, 30 Jul 2015 10:16:19 +0300 Message-ID: <87si869ku4.fsf@ashishki-desk.ger.corp.intel.com> References: <1436177344-16751-1-git-send-email-alexander.shishkin@linux.intel.com> <1436177344-16751-2-git-send-email-alexander.shishkin@linux.intel.com> <877fpjkseh.fsf@ashishki-desk.ger.corp.intel.com> <87vbd29mm6.fsf@ashishki-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chunyan Zhang Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Mathieu Poirier , peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, "linux-api@vger.kernel.org" , Chunyan Zhang , Mark Brown List-Id: linux-api@vger.kernel.org Chunyan Zhang writes: > The code has already been submitted like I said in the earlier emails, > you may refer [1]. > > Thanks, > Chunyan > > [1] https://lkml.org/lkml/2015/2/4/729 This code does the following (pasting from that patch): in stm_probe(): drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); ... something irrelevant ... ret = clk_prepare_enable(drvdata->clk); ... something irrelevant ... clk_disable_unprepare(drvdata->clk); ... something irrelevant ... drvdata->clk = adev->pclk; How is this supposed to even work? Regards, -- Alex