From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE274C433F5 for ; Wed, 27 Oct 2021 13:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8808961056 for ; Wed, 27 Oct 2021 13:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240324AbhJ0NFq (ORCPT ); Wed, 27 Oct 2021 09:05:46 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57904 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbhJ0NFp (ORCPT ); Wed, 27 Oct 2021 09:05:45 -0400 Received: from localhost (unknown [IPv6:2804:14c:124:8a08::1002]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: krisman) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 96E881F44480; Wed, 27 Oct 2021 14:03:18 +0100 (BST) From: Gabriel Krisman Bertazi To: Amir Goldstein Cc: Jan Kara , Jan Kara , "Darrick J. Wong" , Theodore Tso , Dave Chinner , David Howells , Khazhismel Kumykov , linux-fsdevel , Linux API , Ext4 , kernel@collabora.com Subject: Re: [PATCH v9 00/31] file system-wide error monitoring Organization: Collabora References: <20211025192746.66445-1-krisman@collabora.com> <20211027112243.GE28650@quack2.suse.cz> Date: Wed, 27 Oct 2021 10:03:13 -0300 In-Reply-To: (Amir Goldstein's message of "Wed, 27 Oct 2021 15:36:38 +0300") Message-ID: <87y26ed3hq.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org Amir Goldstein writes: > On Wed, Oct 27, 2021 at 2:22 PM Jan Kara wrote: >> >> On Tue 26-10-21 12:12:38, Amir Goldstein wrote: >> > On Mon, Oct 25, 2021 at 10:27 PM Gabriel Krisman Bertazi >> > wrote: >> > > >> > > Hi, >> > > >> > > This is the 9th version of this patch series. Thank you, Amir, Jan and >> > > Ted, for the feedback in the previous versions. >> > > >> > > The main difference in this version is that the pool is no longer >> > > resizeable nor limited in number of marks, even though we only >> > > pre-allocate 32 slots. In addition, ext4 was modified to always return >> > > non-zero errno, and the documentation was fixed accordingly (No longer >> > > suggests we return EXT4_ERR* values. >> > > >> > > I also droped the Reviewed-by tags from the ext4 patch, due to the >> > > changes above. >> > > >> > > Please let me know what you think. >> > > >> > >> > All good on my end. >> > I've made a couple of minor comments that >> > could be addressed on commit if no other issues are found. >> >> All good on my end as well. I've applied all the minor updates, tested the >> result and pushed it out to fsnotify branch of my tree. WRT to your new >> FS_ERROR LTP tests, I've noticed that the testcases 1 and 3 from test >> fanotify20 fail for me. After a bit of debugging this seems to be a bug in >> ext4 where it calls ext4_abort() with EXT4_ERR_ESHUTDOWN instead of plain >> ESHUTDOWN. Not sure if you have that fixed or how come the tests passed for >> you. After fixing that ext4 bug everything passes for me. >> > > Gabriel mentioned that bug in the cover letter of the LTP series :-) > https://lore.kernel.org/linux-ext4/20211026173302.84000-1-krisman@collabora.com/T/#u Yes :) Also, thank you both for the extensive review and ideas during the development of this series. It was really appreciated! I'm sending out the new version for tests + man pages today. -- Gabriel Krisman Bertazi