From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F4BA26E175 for ; Tue, 18 Feb 2025 16:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739895451; cv=none; b=VrcUZz7N3dcP5WWAGMs/c4pKjuBxquJeNY+eEhMyGJgYe7nNjDLZD1tIqaL0AmhUNu7/7/B5SxmGWv0U1Jg2N3Ip1mNClifbPynaUSpENf28Baa8OSlfEQPGawU2727ujsECsYvJnJlayd2eZuOJDADLXL/jidf39Ucc8Zu/3tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739895451; c=relaxed/simple; bh=gMNXeKXfGJGpSLe7hk9zBDvoqpHd9qta3Kra/mOHGWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qY4oRvvRAFsU6F3cd+le+me+YQVfngUKBaRe4+YDaCDEcAynpbOSqFWTHWM4cWrLeB5naJDdgvFniDFzosktQlIK9tYwx8i4DY+oNf0aBtDbYpqxBA1Y4ZUhkXETOrv1eT54ODzeq3YiuT9STfkGrMWppG0OJp+iM2LX5DNkjGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T5X4f7z6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T5X4f7z6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739895447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+zX8vDm6losC/6+HQlwhAMeERFE1g3IHX/DgdG0yftY=; b=T5X4f7z6uEHetg0WcoNFS6D6MMCgfdYr586dnAHX2aJPf3UJDuPZxVi/OTXHwtAEE7XEkx 12h5zX8bMIe8sGKeTh/YlJbefydfNcY9mDZa+RKATQDnyE4kaxQUyZHS94Npl5CHAOoawK 9ly5GPMcVu/+fqnrh7V7oj2NccR6a+o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-U2TUkH4pP4GoLbrNTeg2xw-1; Tue, 18 Feb 2025 11:17:25 -0500 X-MC-Unique: U2TUkH4pP4GoLbrNTeg2xw-1 X-Mimecast-MFC-AGG-ID: U2TUkH4pP4GoLbrNTeg2xw_1739895445 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4394b2c19ccso46712505e9.1 for ; Tue, 18 Feb 2025 08:17:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739895444; x=1740500244; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+zX8vDm6losC/6+HQlwhAMeERFE1g3IHX/DgdG0yftY=; b=h5x96aNpH1/qiDb5D7oTqppqhNWsxGjHJ4/7prhY9ayHRGMxPrNVMhlF+GfnGffN27 G/A6BPDRMwThkm3TlkWC2KMJ0cBDcRSy0wuLXRKMQBPpv91t04orl4+73nfMpGmC5mDW 8v8EsoY1AhfNAQBqwWgPArFCVb0jjNzit/rhWkjw3dpI58uKbUILkwhv15ot/ZKjaeeB k5u8O5Jc5yRG10mYsVIdtd7XBI7sJwtoxCqbUOxpoxcIQeWuVpajpaUEZ3ntHz4sY01C DVwjipmD2qiD6b+/IYCSQvfPG9BP059fCEumIJ51Gusj9KN427aejyX8SGPQxpI/X4nK vTQA== X-Forwarded-Encrypted: i=1; AJvYcCWDMTEmRml4J1xzJPulfmMUT/ICynriXHt28tucnFIXKWQjiBtSOPlcv1b7K+8oJ5yuidT7AUzmV5A=@vger.kernel.org X-Gm-Message-State: AOJu0YxpWWfZ61WWWqW1LD816/ZqK1yRlHmh0iMN01cgpMk336RYNMwh dASCOL0SlWU1hoZhwEsAT2NVn++4TmKjQ+/UY4VHtJEXhsMQOg3O47RnVPlD2JUWiGi/3hFf+F2 C6CSgGnEUtZkhp5zVUx8hJt/mDXssjjhn0l+yiU8wiFbwwlt6u4Kt3zvPhQ== X-Gm-Gg: ASbGncuAofwsSat5mBCpWQU07ynNWh81qKP0LVMiwYeyOACf2+nWfkX9tOJWfa1C5s9 751UyP0xPxW9oNTNUgD717NOG8lt8Qr5Ibco7WZ4kmCv7JqqvCjph8x4cL5maEA0PpsJkAGIvdX lKscDDMT5dsoFiYCIENH8+7NZx0XNZQqMwfC4Ya8hbo4jQfIVZsx/DVICv0a9U2JFXgoMP4ormY w6iUEmDe1HaT9cIPwNLDnVhHqvD/kOBqPm4nDC2wYVQrcqnFx3zeieocdJaoe+oBMKYfpevnZ6D /Td7kM8DpMoHT4Zo/E27TG72Ee2BbOfgOIHuDRhAcw6vkS3n3WSBNlsjGT81GHHnvC9pheZcWmL y//vq85Y0O+qgOJ5ap1xK919n64L/6AMR X-Received: by 2002:adf:ed48:0:b0:38d:d5af:29b4 with SMTP id ffacd0b85a97d-38f33f565b6mr12666004f8f.45.1739895444598; Tue, 18 Feb 2025 08:17:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEggc/z/NkvkoSqpYbRnyzbugIdCUlVVI8F8Qnaw5coeupOpTLWVK06VHLWuhVQarriChoZsA== X-Received: by 2002:adf:ed48:0:b0:38d:d5af:29b4 with SMTP id ffacd0b85a97d-38f33f565b6mr12665975f8f.45.1739895444156; Tue, 18 Feb 2025 08:17:24 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af? (p200300cbc70dfb00d3ed5f441b2d12af.dip0.t-ipconnect.de. [2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439948eb34esm22389965e9.38.2025.02.18.08.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2025 08:17:22 -0800 (PST) Message-ID: <90a00957-02b5-440a-9168-de93c760fea7@redhat.com> Date: Tue, 18 Feb 2025 17:17:20 +0100 Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: allow guard regions in file-backed and read-only mappings To: Lorenzo Stoakes Cc: Andrew Morton , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, John Hubbard , Juan Yescas , Kalesh Singh References: <6500a93f-aad1-4b21-a94e-feb493c344a3@redhat.com> <4d6d2942-10a1-46e8-93a6-7ce52b6af3ad@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4d6d2942-10a1-46e8-93a6-7ce52b6af3ad@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18.02.25 17:12, Lorenzo Stoakes wrote: > On Tue, Feb 18, 2025 at 05:01:16PM +0100, David Hildenbrand wrote: >> On 13.02.25 19:17, Lorenzo Stoakes wrote: >>> There is no reason to disallow guard regions in file-backed mappings - >>> readahead and fault-around both function correctly in the presence of PTE >>> markers, equally other operations relating to memory-mapped files function >>> correctly. >>> >>> Additionally, read-only mappings if introducing guard-regions, only >>> restrict the mapping further, which means there is no violation of any >>> access rights by permitting this to be so. >>> >>> Removing this restriction allows for read-only mapped files (such as >>> executable files) correctly which would otherwise not be permitted. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >>> mm/madvise.c | 8 +------- >>> 1 file changed, 1 insertion(+), 7 deletions(-) >>> >>> diff --git a/mm/madvise.c b/mm/madvise.c >>> index 6ecead476a80..e01e93e179a8 100644 >>> --- a/mm/madvise.c >>> +++ b/mm/madvise.c >>> @@ -1051,13 +1051,7 @@ static bool is_valid_guard_vma(struct vm_area_struct *vma, bool allow_locked) >>> if (!allow_locked) >>> disallowed |= VM_LOCKED; >>> - if (!vma_is_anonymous(vma)) >>> - return false; >>> - >>> - if ((vma->vm_flags & (VM_MAYWRITE | disallowed)) != VM_MAYWRITE) >>> - return false; >>> - >>> - return true; >>> + return !(vma->vm_flags & disallowed); >>> } >>> static bool is_guard_pte_marker(pte_t ptent) >> >> Acked-by: David Hildenbrand > > Thanks! > >> >> I assume these markers cannot completely prevent us from allocating >> pages/folios for these underlying file/pageache ranges of these markers in >> case of shmem during page faults, right? > > If the markers are in place, then page faulting will result in a > segfault. If we faulted in a shmem page then installed markers (which would > zap the range), then the page cache will be populated, but obviously > subject to standard reclaim. Well, yes, (a) if there is swap and (b), if the noswap option was not specified for tmpfs. Okay, so installing a guard entry might require punshing a hole to get rid of any already-existing memory. But readahead (below) might mess it up. > > If we perform synchronous readahead prior to a guard region that includes > (partially or fully) a guard region we might major fault entries into the > page cache that are then not accessable _from that mapping_, this is rather > unavoidable as this doesn't account for page table mappings and should be > largely trivial overhead (also these folios are reclaimable). Right, that's what I had in mind: assume I have a single marker in a PMD, shmem might allocate a PMD THP to back that region, ignoring the marker hint. (so I think) Thanks! -- Cheers, David / dhildenb