From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: UAPI headers including non-UAPI headers by accident?
Date: Thu, 18 Jun 2015 09:58:52 +0200 [thread overview]
Message-ID: <9141492.JqTlmk9dHk@wuerfel> (raw)
In-Reply-To: <CAKgNAkjLmBUayYjVOr6Stcbmcn=ENb3Uyt0dkFQCmn-Lxdn0xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thursday 18 June 2015 09:52:36 Michael Kerrisk wrote:
> [CC += David]
>
> On 2 June 2015 at 18:36, Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > include/uapi/linux/signal.h starts with:
> >
> > #ifndef _UAPI_LINUX_SIGNAL_H
> > #define _UAPI_LINUX_SIGNAL_H
> >
> > #include <asm/signal.h>
> > #include <asm/siginfo.h>
> >
> > This causes it to include <asm/signal.h>, which is not the same thing
> > as <uapi/asm/signal.h>. Changing that will break userspace use of
> > this header, though, as the uapi/ won't get removed.
> >
> > What's the correct fix? This is causing trouble with a UML build for me.
>
> Perhaps David has some insight, since he architected the original UAPI split.
The uapi headers are installed without the uapi prefix. This means
that inside of the kernel, we get
linux/signal.h
-> uapi/linux/signal.h
-> asm/signal.h
-> uapi/asm/signal.h
while in the installed headers we just get
linux/signal.h
-> asm/signal.h
This all looks right to me: user space only sees the exported portions
under the traditional names, while the kernel sees both the kernel-side
and user-side definitions from the same path.
Arnd
next prev parent reply other threads:[~2015-06-18 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 16:36 UAPI headers including non-UAPI headers by accident? Andy Lutomirski
[not found] ` <CALCETrVaWJVDFydhXv320iCuFhTMi9txx+MpzsA_Q7yeZxMDSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-18 7:52 ` Michael Kerrisk (man-pages)
[not found] ` <CAKgNAkjLmBUayYjVOr6Stcbmcn=ENb3Uyt0dkFQCmn-Lxdn0xw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-18 7:58 ` Arnd Bergmann [this message]
2015-06-18 18:57 ` Andy Lutomirski
[not found] ` <CALCETrVxa9U9GMOnPZ5cAnPJvtCqjia1J1e5YBET6deAPKU82g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-23 20:44 ` Arnd Bergmann
2015-06-23 21:20 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9141492.JqTlmk9dHk@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox