From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA046C433DF for ; Mon, 24 Aug 2020 18:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9902F206BE for ; Mon, 24 Aug 2020 18:52:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="IZzd4ap3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbgHXSw3 (ORCPT ); Mon, 24 Aug 2020 14:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgHXSw1 (ORCPT ); Mon, 24 Aug 2020 14:52:27 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C05C061575 for ; Mon, 24 Aug 2020 11:52:27 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id y65so596780qtd.2 for ; Mon, 24 Aug 2020 11:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/a87U3xOIsepXqYxdXZyC67pPTYVYefQcfmWIfEUAdQ=; b=IZzd4ap3bSsv82zPm8HZR1QrAFc4aPstasMKpdH9fAGqnOZeRREXW1ml9vm3M+zH1j Iid0qCkyoDnQ7Gp+rQFgWZDOONNbCUWqxTYW38+4ITFteD2Mf+8aLc44+ecIGM9+mUXp exTRVlmDtmlciJidQjLyEugzTYdPVkRzv9rnK2oHgzQHMRnCxOP3XTrtH/o29RlCy5zn ui62uTIgeLIMW2xlL+o6+M0Av7VFVGbakljYqAreFJ/i5kFHoNSwINmo1EyxNxwDyjc4 CrlwjTwTdzhulvt71JAhRWNnZ6nGoYdjmHK1IIzvGZNLkorMx6+xvi3SrtEpeFsfNGVO hzqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/a87U3xOIsepXqYxdXZyC67pPTYVYefQcfmWIfEUAdQ=; b=iNHCAPegken8sWVLruc7cHNi9bXZXzMOmpz1wPOG1M2op3dVl0wc+m9UAisQ5CT/6D sz7kxpTi3T9B/lLwGIa75jrmZUIjaborWyFje9gWCaimz/xqixwJu99C3VuhdTVEcOXG gt7UECHxHNHN4E4AF/nQXw1d94s4uw8AgS8U/PRqskq0nixBY7XipofqgwLKLk0b1tEE DaeGkhXtmPjs65fj7D+rCildHBEzrwt63VDi1IK/T1iLEp9LrxoqwgdQtgLLYskCWdza LBCi1y5nUBWr1F0TuSoFksFdJyttDm7fS89YdXToSSrKHg7kme9ij9dxbiVT4APCyPNL bQrA== X-Gm-Message-State: AOAM533YSxTGBJXOfk2sT2dHgoIj/VqNiGUxVDtjrXwPpwSCw1QmlVCW yc0jIc2wQ9Oox1+e39r4/qI88w== X-Google-Smtp-Source: ABdhPJygV/nBVHEX/50hfW861ZSzyEdIO8Q5zPGw2DgDUDPPFLhBT4KyvO3z+Zq840xPgfWOgaJNYA== X-Received: by 2002:aed:3ac7:: with SMTP id o65mr6169171qte.11.1598295146628; Mon, 24 Aug 2020 11:52:26 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id 22sm10205679qkd.64.2020.08.24.11.52.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 11:52:26 -0700 (PDT) Subject: Re: [PATCH v5 1/9] iov_iter: add copy_struct_from_iter() To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: <8010f8862ec494c631b1d7681a6c5886d12f60df.1597993855.git.osandov@osandov.com> From: Josef Bacik Message-ID: <93eca2d1-f72c-2181-b6a4-7015886f2418@toxicpanda.com> Date: Mon, 24 Aug 2020 14:52:24 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <8010f8862ec494c631b1d7681a6c5886d12f60df.1597993855.git.osandov@osandov.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 8/21/20 3:38 AM, Omar Sandoval wrote: > From: Omar Sandoval > > This is essentially copy_struct_from_user() but for an iov_iter. > > Suggested-by: Aleksa Sarai > Signed-off-by: Omar Sandoval This took me a lot longer to grok than I'm proud of, but the idea is you'll have a single segment that represents the incoming encoded data, and then subsequent segments will be the read/write buffer, correct? The code looks fine to me, Reviewed-by: Josef Bacik Thanks, Josef