From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F90928751D; Fri, 23 Jan 2026 15:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769183405; cv=none; b=TTF6JMw8Xwxw+K9iaTE2pmeSWotJeh/7v9a+nLsykETjm12C3cRxxfoqsjH9G8WQwHQt+/lhZJrkTKa4NyOnaYIsGh89Kwne79pntg+6JrkjqOfll8GMUAR0y5nsKq8gCUQP7+9KmDrb0dzyxmEJ1unPNRhi6mevuMTQyrYb5lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769183405; c=relaxed/simple; bh=kDP9Yb3CbfggR8X+hWoqLQMPd20AumtY0Il/c8TNaKY=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=Ca5jGWz6WrM5WBETKs7kcZMzz61dcfgoVHSB+FzHoUIdSgO1ykeqPJWDHUMJ9b599WARaZ4zF+cqW5o2K8xwiMVpzitOvujaQj3ZkeAXVcGhiumnRtAFZXo5thOis2Yg0xPVqJUlploC4fgliKCYF5WGrH8wW+xQxS4hx9xyypM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Oe08t/o/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Oe08t/o/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 268FAC4CEF1; Fri, 23 Jan 2026 15:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769183405; bh=kDP9Yb3CbfggR8X+hWoqLQMPd20AumtY0Il/c8TNaKY=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=Oe08t/o/2NDsUrMKUH1M6DPGJM2ZN7cDoW08+cOE4juSlAGvrXORrSwCclCZw2aDV ZkVTKgFOWWiO1/7UD1FizCrSF5aPkbMt0Xz4yP7v5wFhzCq1Ehfu3cawiSSiJn4aFe tMl2S1/Ku9JhhGFB7uQXeL5ZqG6ZVdbkqwNvLCmPFT6cK/SRjDjHv08QbhhTdsOSlg YMufXMi1X8phtUbamkl5WfuMZM1sjX7V2NmsZD7t/TCp+rOJJNc02MHDzBzX/GOr5L jR8J1YHTCxnnSmEGS1fVMkvtoFxQA5PdCm3odBjzpdLrYydUjdPpPGZlr8mqEYL1Up hVo8FmzWqbd9w== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 0A23CF40068; Fri, 23 Jan 2026 10:50:03 -0500 (EST) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Fri, 23 Jan 2026 10:50:03 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugeelgeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfvehhuhgt khcunfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrh hnpefhffekffeftdfgheeiveekudeuhfdvjedvfedvueduvdegleekgeetgfduhfefleen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhhutg hklhgvvhgvrhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeifeegleel leehledqfedvleekgeegvdefqdgtvghlpeepkhgvrhhnvghlrdhorhhgsehfrghsthhmrg hilhdrtghomhdpnhgspghrtghpthhtohepfeefpdhmohguvgepshhmthhpohhuthdprhgt phhtthhopehsvghnohiihhgrthhskhihsegthhhrohhmihhumhdrohhrghdprhgtphhtth hopegrughilhhgvghrrdhkvghrnhgvlhesughilhhgvghrrdgtrgdprhgtphhtthhopehs lhgrvhgrseguuhgsvgihkhhordgtohhmpdhrtghpthhtoheprhhonhhnihgvshgrhhhlsg gvrhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghnnhgrsehkvghrnhgvlhdrohhr ghdprhgtphhtthhopegsrhgruhhnvghrsehkvghrnhgvlhdrohhrghdprhgtphhtthhope gtvghmsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhgroheskhgvrhhnvghlrdho rhhgpdhrtghpthhtohepughjfihonhhgsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id D0B1A780075; Fri, 23 Jan 2026 10:50:02 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AX_vFn8fWldV Date: Fri, 23 Jan 2026 10:49:38 -0500 From: "Chuck Lever" To: "Darrick J. Wong" Cc: "Alexander Viro" , "Christian Brauner" , "Jan Kara" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, "OGAWA Hirofumi" , "Namjae Jeon" , "Sungjong Seo" , "Yuezhang Mo" , almaz.alexandrovich@paragon-software.com, "Viacheslav Dubeyko" , glaubitz@physik.fu-berlin.de, frank.li@vivo.com, "Theodore Tso" , adilger.kernel@dilger.ca, "Carlos Maiolino" , "Steve French" , "Paulo Alcantara" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Trond Myklebust" , "Anna Schumaker" , "Jaegeuk Kim" , "Chao Yu" , "Hans de Goede" , senozhatsky@chromium.org, "Chuck Lever" Message-Id: <95aa2a65-e1e8-44ef-a62a-e3190a11cb32@app.fastmail.com> In-Reply-To: <20260123002904.GM5945@frogsfrogsfrogs> References: <20260122160311.1117669-1-cel@kernel.org> <20260122160311.1117669-8-cel@kernel.org> <20260123002904.GM5945@frogsfrogsfrogs> Subject: Re: [PATCH v7 07/16] ext4: Report case sensitivity in fileattr_get Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Jan 22, 2026, at 7:29 PM, Darrick J. Wong wrote: > On Thu, Jan 22, 2026 at 11:03:02AM -0500, Chuck Lever wrote: >> From: Chuck Lever >> >> Report ext4's case sensitivity behavior via the FS_XFLAG_CASEFOLD >> flag. ext4 always preserves case at rest. >> >> Case sensitivity is a per-directory setting in ext4. If the queried >> inode is a casefolded directory, report case-insensitive; otherwise >> report case-sensitive (standard POSIX behavior). >> >> Reviewed-by: Jan Kara >> Signed-off-by: Chuck Lever >> --- >> fs/ext4/ioctl.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c >> index 7ce0fc40aec2..462da7aadc80 100644 >> --- a/fs/ext4/ioctl.c >> +++ b/fs/ext4/ioctl.c >> @@ -996,6 +996,13 @@ int ext4_fileattr_get(struct dentry *dentry, struct file_kattr *fa) >> if (ext4_has_feature_project(inode->i_sb)) >> fa->fsx_projid = from_kprojid(&init_user_ns, ei->i_projid); >> >> + /* >> + * Case folding is a directory attribute in ext4. Set FS_XFLAG_CASEFOLD >> + * for directories with the casefold attribute; all other inodes use >> + * standard case-sensitive semantics. >> + */ >> + if (IS_CASEFOLDED(inode)) >> + fa->fsx_xflags |= FS_XFLAG_CASEFOLD; > > Curious. Shouldn't the VFS set FS_XFLAG_CASEFOLD if the VFS casefolding > flag is set? > > OTOH, there are more filesystems that apparently support casefolding > (given the size of this patchset) than actually set S_CASEFOLD. I think > I'm ignorant of something here... I'm not clear if there's a review action needed. Help? -- Chuck Lever