From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [RFC PATCH for 4.15 19/24] membarrier: selftest: Test shared expedited cmd Date: Fri, 17 Nov 2017 08:07:19 -0700 Message-ID: <9e0e1b65-337f-4f0e-7e55-6cee8c17a507@osg.samsung.com> References: <20171114200414.2188-1-mathieu.desnoyers@efficios.com> <20171114200414.2188-20-mathieu.desnoyers@efficios.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171114200414.2188-20-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org> Content-Language: en-US Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mathieu Desnoyers , Peter Zijlstra , "Paul E . McKenney" , Boqun Feng , Andy Lutomirski , Dave Watson Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Turner , Andrew Morton , Russell King , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andrew Hunter , Andi Kleen , Chris Lameter , Ben Maurer , Steven Rostedt , Josh Triplett , Linus Torvalds , Catalin Marinas , Will Deacon , Michael Kerrisk , Greg Kroah-Hartman , Maged Michael , Avi Kivity List-Id: linux-api@vger.kernel.org On 11/14/2017 01:04 PM, Mathieu Desnoyers wrote: > Test the new MEMBARRIER_CMD_SHARED_EXPEDITED and > MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED commands. > > Signed-off-by: Mathieu Desnoyers > CC: Shuah Khan > CC: Greg Kroah-Hartman > CC: Peter Zijlstra > CC: Paul E. McKenney > CC: Boqun Feng > CC: Andrew Hunter > CC: Maged Michael > CC: Avi Kivity > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Michael Ellerman > CC: Dave Watson > CC: Alan Stern > CC: Will Deacon > CC: Andy Lutomirski > CC: Alice Ferrazzi > CC: Paul Elder > CC: linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > CC: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > .../testing/selftests/membarrier/membarrier_test.c | 51 +++++++++++++++++++++- > 1 file changed, 50 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/membarrier/membarrier_test.c b/tools/testing/selftests/membarrier/membarrier_test.c > index e6ee73d01fa1..bb9c58072c5c 100644 > --- a/tools/testing/selftests/membarrier/membarrier_test.c > +++ b/tools/testing/selftests/membarrier/membarrier_test.c > @@ -132,6 +132,40 @@ static int test_membarrier_private_expedited_success(void) > return 0; > } > > +static int test_membarrier_register_shared_expedited_success(void) > +{ > + int cmd = MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED, flags = 0; > + const char *test_name = "sys membarrier MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED"; > + > + if (sys_membarrier(cmd, flags) != 0) { > + ksft_exit_fail_msg( > + "%s test: flags = %d, errno = %d\n", > + test_name, flags, errno); > + } > + > + ksft_test_result_pass( > + "%s test: flags = %d\n", > + test_name, flags); > + return 0; > +} > + > +static int test_membarrier_shared_expedited_success(void) > +{ > + int cmd = MEMBARRIER_CMD_SHARED_EXPEDITED, flags = 0; > + const char *test_name = "sys membarrier MEMBARRIER_CMD_SHARED_EXPEDITED"; > + > + if (sys_membarrier(cmd, flags) != 0) { > + ksft_exit_fail_msg( > + "%s test: flags = %d, errno = %d\n", > + test_name, flags, errno); > + } > + > + ksft_test_result_pass( > + "%s test: flags = %d\n", > + test_name, flags); > + return 0; > +} > + > static int test_membarrier(void) > { > int status; > @@ -154,6 +188,19 @@ static int test_membarrier(void) > status = test_membarrier_private_expedited_success(); > if (status) > return status; > + /* > + * It is valid to send a shared membarrier from a non-registered > + * process. > + */ > + status = test_membarrier_shared_expedited_success(); > + if (status) > + return status; > + status = test_membarrier_register_shared_expedited_success(); > + if (status) > + return status; > + status = test_membarrier_shared_expedited_success(); > + if (status) > + return status; > return 0; > } > > @@ -173,8 +220,10 @@ static int test_membarrier_query(void) > } > ksft_exit_fail_msg("sys_membarrier() failed\n"); > } > - if (!(ret & MEMBARRIER_CMD_SHARED)) > + if (!(ret & MEMBARRIER_CMD_SHARED)) { > + ksft_test_result_fail("sys_membarrier() CMD_SHARED query failed\n"); > ksft_exit_fail_msg("sys_membarrier is not supported.\n"); > + } > > ksft_test_result_pass("sys_membarrier available\n"); > return 0; > Looks good to me. I am assuming this patch goes in with the rest of the series. For this patch: Acked-by: Shuah Khan thanks, -- Shuah