From: "Tautschnig, Michael" <tautschn-vV1OtcyAfmbQXOPxS62xeg@public.gmane.org>
To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
Cc: "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jaswinder Singh
<jaswinder-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Andi Kleen <ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH] Syscall arguments are unsigned long (full registers)
Date: Mon, 4 Jul 2016 20:13:21 +0000 [thread overview]
Message-ID: <C9F705AD-41A0-48CF-8A3E-507C12EB5D0E@amazon.com> (raw)
In-Reply-To: <C22BF648-D579-4B23-8BF6-C18033433F22-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
> On 4 Jul 2016, at 20:27, H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org> wrote:
>
> On July 4, 2016 6:52:58 AM PDT, "Tautschnig, Michael" <tautschn-vV1OtcyAfmbQXOPxS62xeg@public.gmane.org> wrote:
>> All syscall arguments are passed in as types of the same byte size as
>> unsigned long (width of full registers). Using a smaller type without a
>> cast may result in losing bits of information. In all other instances
>> apart from the ones fixed by the patch the code explicitly introduces
>> type casts (using, e.g., SYSCALL_DEFINE1).
>>
>> While goto-cc reported these problems at build time, it is noteworthy
>> that the calling conventions specified in the System V AMD64 ABI do
>> ensure that parameters 1-6 are passed via registers, thus there is no
>> implied risk of misaligned stack access.
>>
>>
[...]
>
> Wrong. Syscall arguments aren't necessarily full registers, and on x86 truncation is already done by the callee, so we don't need any special handing. Some other architectures have other constraints.
Ok - I'm assuming I have thus misunderstood eb974c62565072e10c1422eb3205f5b611dd99a1 ? Supposedly all those SYSCALL_DEFINEx are required for other architectures only?
Best,
Michael
next prev parent reply other threads:[~2016-07-04 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:52 [PATCH] Syscall arguments are unsigned long (full registers) Tautschnig, Michael
[not found] ` <A9946D15-1553-417B-BD0C-6C65AA2122B3-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2016-07-04 14:28 ` Andi Kleen
[not found] ` <20160704142802.GL25121-KWJ+5VKanrL29G5dvP0v1laTQe2KTcn/@public.gmane.org>
2016-07-04 14:47 ` Tautschnig, Michael
[not found] ` <ED0D99E6-1A18-4263-B227-7105313FA6AC-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2016-07-04 14:59 ` Arnd Bergmann
2016-07-04 15:13 ` Tautschnig, Michael
2016-07-04 18:27 ` H. Peter Anvin
[not found] ` <C22BF648-D579-4B23-8BF6-C18033433F22-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2016-07-04 20:13 ` Tautschnig, Michael [this message]
[not found] ` <C9F705AD-41A0-48CF-8A3E-507C12EB5D0E-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2016-07-04 20:23 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9F705AD-41A0-48CF-8A3E-507C12EB5D0E@amazon.com \
--to=tautschn-vv1otcyafmbqxopxs62xeg@public.gmane.org \
--cc=ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=jaswinder-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox