From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Lad Subject: Re: [PATCH v7 44/46] virtio_scsi: export to userspace Date: Sun, 30 Nov 2014 21:43:23 +0000 Message-ID: References: <1417359787-10138-1-git-send-email-mst@redhat.com> <1417359787-10138-45-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1417359787-10138-45-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Michael S. Tsirkin" Cc: LKML , David Miller , cornelia.huck-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, rusty-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org, nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, thuth-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, dahi-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Rusty Russell , Greg Kroah-Hartman , Alexei Starovoitov , Bjarke Istrup Pedersen , Andy Grover , stephen hemminger , Sakari Ailus , Anup Patel , linux-api , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-api@vger.kernel.org Hi Michael, Thanks for the patch. On Sun, Nov 30, 2014 at 3:12 PM, Michael S. Tsirkin wrote: > Replace uXX by __uXX and _packed by __attribute((packed)) > as seems to be the norm for userspace headers. > > Signed-off-by: Michael S. Tsirkin > Acked-by: Paolo Bonzini > --- > include/uapi/linux/virtio_scsi.h | 74 ++++++++++++++++++++-------------------- > include/uapi/linux/Kbuild | 1 + Probably worth making a separate patch for this ? as it doesnt match with patch description aswel. Apart from that patch looks good. Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad