From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Turner Subject: Re: [PATCH 2/2] ipc: fix sparc64 ipc() wrapper Date: Thu, 5 Sep 2019 10:22:36 -0700 Message-ID: References: <20190905152155.1392871-1-arnd@arndb.de> <20190905152155.1392871-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190905152155.1392871-2-arnd@arndb.de> Sender: stable-owner@vger.kernel.org To: Arnd Bergmann Cc: LKML , Andrew Morton , "David S. Miller" , "Eric W. Biederman" , Deepa Dinamani , Christian Brauner , Manfred Spraul , Davidlohr Bueso , Linux-Arch , y2038 Mailman List , Dominik Brodowski , stable@vger.kernel.org, sparclinux@vger.kernel.org, Linux API List-Id: linux-api@vger.kernel.org On Thu, Sep 5, 2019 at 8:23 AM Arnd Bergmann wrote: > > Matt bisected a sparc64 specific issue with semctl, shmctl and msgctl > to a commit from my y2038 series in linux-5.1, as I missed the custom > sys_ipc() wrapper that sparc64 uses in place of the generic version that > I patched. > > The problem is that the sys_{sem,shm,msg}ctl() functions in the kernel > now do not allow being called with the IPC_64 flag any more, resulting > in a -EINVAL error when they don't recognize the command. > > Instead, the correct way to do this now is to call the internal > ksys_old_{sem,shm,msg}ctl() functions to select the API version. > > As we generally move towards these functions anyway, change all of > sparc_ipc() to consistently use those in place of the sys_*() versions, > and move the required ksys_*() declarations into linux/syscalls.h > > Reported-by: Matt Turner > Fixes: 275f22148e87 ("ipc: rename old-style shmctl/semctl/msgctl syscalls") > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann > --- > Hi Matt, > > Can you check that this solves your problem? Works great. Thank you Arnd! Tested-by: Matt Turner