linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jiri Olsa <olsajiri@gmail.com>, Aleksa Sarai <cyphar@cyphar.com>,
	 Eyal Birger <eyal.birger@gmail.com>,
	mhiramat@kernel.org,  linux-kernel <linux-kernel@vger.kernel.org>,
	linux-trace-kernel@vger.kernel.org,
	 BPF-dev-list <bpf@vger.kernel.org>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	 John Fastabend <john.fastabend@gmail.com>,
	peterz@infradead.org, tglx@linutronix.de,  bp@alien8.de,
	x86@kernel.org, linux-api@vger.kernel.org,
	 Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Alexei Starovoitov <ast@kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	rafi@rbk.io,  Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: Re: Crash when attaching uretprobes to processes running in Docker
Date: Tue, 14 Jan 2025 15:52:23 -0800	[thread overview]
Message-ID: <CAEf4BzZquQBW1DuEmfhUTicoyHOeEpT6FG7VBR-kG35f7Rb5Zw@mail.gmail.com> (raw)
In-Reply-To: <20250114221002.GA10122@redhat.com>

On Tue, Jan 14, 2025 at 2:11 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 01/14, Andrii Nakryiko wrote:
> >
> > On Tue, Jan 14, 2025 at 12:40 PM Oleg Nesterov <oleg@redhat.com> wrote:
> > >
> > > But, unlike sys_uretprobe(), sys_rt_sigreturn() is old, so the existing
> > > setups must know that sigreturn() should be respected...
> >
> > someday sys_uretprobe will be old as well ;) FWIW, systemd allowlisted
> > sys_uretprobe, see [0]
>
> And I agree! ;)
>
> I mean, I'd personally prefer to do nothing and wait until userspace figures
> out that we have another "special" syscall.
>
> But can we do it? I simply do not know. Can we ignore this (valid) bug report?
>

Seems wrong for kernel to try to guess whether some syscall is
filtered by some policy or not (though maybe I'm misunderstanding the
details and it's kernel-originated problem?). Seems like a recipe for
more problems.

Nothing is really fundamentally broken. Some piece of software needs
an upgraded library to not disable the kernel's special syscall (just
like sys_rt_sigreturn, nothing "new" here, really). Users can't do
uprobing in such broken setups (but not in general), seems like a good
incentive for everyone to push for the right thing here: fixed up to
date software.

> Oleg.
>

  reply	other threads:[~2025-01-14 23:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 15:12 Crash when attaching uretprobes to processes running in Docker Eyal Birger
2025-01-10 15:25 ` Aleksa Sarai
2025-01-11 18:40   ` Jiri Olsa
2025-01-14  9:22     ` Jiri Olsa
2025-01-14 10:05       ` Masami Hiramatsu
2025-01-14 11:21         ` Oleg Nesterov
2025-01-14 14:21           ` Jiri Olsa
2025-01-17  1:23             ` Masami Hiramatsu
2025-01-17  1:57               ` Oleg Nesterov
2025-01-14 10:42       ` Peter Zijlstra
2025-01-14 11:01         ` Oleg Nesterov
2025-01-14 12:02           ` Peter Zijlstra
2025-01-14 12:32             ` Oleg Nesterov
2025-01-14 14:07               ` Peter Zijlstra
2025-01-14 17:43                 ` Oleg Nesterov
2025-01-14 10:58       ` Oleg Nesterov
2025-01-14 14:19         ` Jiri Olsa
2025-01-14 19:21           ` Andrii Nakryiko
2025-01-14 20:39             ` Oleg Nesterov
2025-01-14 21:45               ` Andrii Nakryiko
2025-01-14 22:10                 ` Oleg Nesterov
2025-01-14 23:52                   ` Andrii Nakryiko [this message]
2025-01-15  0:09                     ` Eyal Birger
2025-01-15  0:50                       ` Oleg Nesterov
2025-01-15  5:45                         ` Shmulik Ladkani
2025-01-15 15:51                           ` Oleg Nesterov
2025-01-17 11:41                 ` Peter Zijlstra
2025-01-17 17:53                   ` Andrii Nakryiko
2025-01-14 14:08       ` Eyal Birger
2025-01-14 14:33         ` Oleg Nesterov
2025-01-14 14:56           ` Jiri Olsa
2025-01-14 17:25             ` Oleg Nesterov
2025-01-15  9:36               ` Jiri Olsa
2025-01-15 13:24                 ` Eyal Birger
2025-01-15 13:25                 ` Jiri Olsa
2025-01-15 15:06                 ` Oleg Nesterov
2025-01-15 17:56                   ` Alexei Starovoitov
2025-01-15 18:20                     ` Andrii Nakryiko
2025-01-15 18:40                     ` Oleg Nesterov
2025-01-15 18:48                       ` Eyal Birger
2025-01-15 19:03                         ` Oleg Nesterov
2025-01-15 21:14                           ` Eyal Birger
2025-01-16 14:39                             ` Oleg Nesterov
2025-01-16 14:47                               ` Eyal Birger
2025-01-16 15:31                                 ` Oleg Nesterov
2025-01-16 17:11                                   ` Eyal Birger
2025-01-17  0:48                                     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZquQBW1DuEmfhUTicoyHOeEpT6FG7VBR-kG35f7Rb5Zw@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=daniel@iogearbox.net \
    --cc=eyal.birger@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=oleg@redhat.com \
    --cc=olsajiri@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rafi@rbk.io \
    --cc=rostedt@goodmis.org \
    --cc=shmulik.ladkani@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).