From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCF1C47E48 for ; Thu, 15 Jul 2021 13:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 023A0613CC for ; Thu, 15 Jul 2021 13:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237629AbhGON2o (ORCPT ); Thu, 15 Jul 2021 09:28:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49566 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237628AbhGON2o (ORCPT ); Thu, 15 Jul 2021 09:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626355550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ah4MbGoLYz8PpeIyy6Wrw1o1Gg/0NPYNIWwDGG2q9MQ=; b=Yjhgzq/9+T6TYDTj+dynlj69arM5UrkCmKAk20jjnNhSrYVT8URBEC8oqVsOkxcpTH8Lzm NKiP1/RUzrLl++zGnllN90+vhBd6bGAsawFHgHDVW7zvmLWRYnatN+PGuJCNg7QfGUhESt 5FRyJX2omwilLAkjRexwCtZ0wBSrp2s= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-nzAtOMmSP46H5bk7-ZOpBA-1; Thu, 15 Jul 2021 09:25:49 -0400 X-MC-Unique: nzAtOMmSP46H5bk7-ZOpBA-1 Received: by mail-lj1-f198.google.com with SMTP id b17-20020a05651c0991b029019189dff65eso1825582ljq.16 for ; Thu, 15 Jul 2021 06:25:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ah4MbGoLYz8PpeIyy6Wrw1o1Gg/0NPYNIWwDGG2q9MQ=; b=P3suQ0rv5AsbeVc7Yxt4vfzhbsh89lffeK9ialpKwXQND37/Ze0lRE0uuQczFUcPap Zq2/JJ7XWimqcxf559NjzZddQOSaf90mm6xW1oz77uMDEGicI2Z1ODijWEHdJ40ujj1h GzeaBxCCTChdte9DsBAlbGsyW61/YmErfkOqWg4ekNV0L1iMXVbIaMq+3Ta3Hd+Tl4mh D4YUJm86xa9S47DUdr4rPOMfQ+ARRROL2P9ZkSjFwoYuPP/dSN5Y/AW6Sn8lGcrD7YCY 9Vfo2PQPegGNzK0cHFQYTvkIFMitjPz8VVUAeJDJpra5AFmZ7VXi2rsgfKjGqtscls+f vfmg== X-Gm-Message-State: AOAM531NvLfzESuWh56A2+iUK9rTigqOHGDm8jn0onakFlDQmLoPgqst kt5Ea1po+pbVH1ENFmi0A5/4sY3pzr4Wytj6x76zmAuu/Qy01CrLTD8ApS8NPT/gTXpPHrFSdzq UviJWzmooFzF9jS7o7xbmjm0XZNLU4g63iDjT X-Received: by 2002:a05:6512:3a86:: with SMTP id q6mr3149864lfu.548.1626355548050; Thu, 15 Jul 2021 06:25:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4dI6Pl2Y//20EnkEGgAcCVbyTORH0YWaTKsr2JdguYEYFI2ihDlt/NUiNtPNi9bYu/OMUSwAlGGsYWpUxV5M= X-Received: by 2002:a05:6512:3a86:: with SMTP id q6mr3149783lfu.548.1626355547649; Thu, 15 Jul 2021 06:25:47 -0700 (PDT) MIME-Version: 1.0 References: <20210713211502.464259-1-nitesh@redhat.com> <20210713211502.464259-7-nitesh@redhat.com> In-Reply-To: From: Nitesh Lal Date: Thu, 15 Jul 2021 09:25:36 -0400 Message-ID: Subject: Re: [PATCH v3 06/14] RDMA/irdma: Use irq_set_affinity_and_hint To: Leon Romanovsky Cc: Nitesh Narayan Lal , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Gleixner , Jesse Brandeburg , Robin Murphy , Marcelo Tosatti , Ingo Molnar , jbrandeb@kernel.org, frederic@kernel.org, Juri Lelli , Alex Belits , Bjorn Helgaas , rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, Marc Zyngier , Neil Horman , pjwaskiewicz@gmail.com, Stefan Assmann , Tomas Henzl , kashyap.desai@broadcom.com, Sumit Saxena , shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, Sreekanth Reddy , suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, Dick Kennedy , Ken Cox , faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, Alaa Hleihel , Kamal Heib , borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, "Nikolova, Tatyana E" , "Ismail, Mustafa" , Al Stone , Chandrakanth Patil Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Wed, Jul 14, 2021 at 9:03 AM Leon Romanovsky wrote: > > On Wed, Jul 14, 2021 at 08:56:41AM -0400, Nitesh Lal wrote: > > On Wed, Jul 14, 2021 at 8:03 AM Leon Romanovsky wrote: > > > > > > On Tue, Jul 13, 2021 at 05:14:54PM -0400, Nitesh Narayan Lal wrote: > > > > The driver uses irq_set_affinity_hint() to update the affinity_hint mask > > > > that is consumed by the userspace to distribute the interrupts and to apply > > > > the provided mask as the affinity for its interrupts. However, > > > > irq_set_affinity_hint() applying the provided cpumask as an affinity for > > > > the interrupt is an undocumented side effect. > > > > > > > > To remove this side effect irq_set_affinity_hint() has been marked > > > > as deprecated and new interfaces have been introduced. Hence, replace the > > > > irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint() > > > > where the provided mask needs to be applied as the affinity and > > > > affinity_hint pointer needs to be set and replace with > > > > irq_update_affinity_hint() where only affinity_hint needs to be updated. > > > > > > > > Signed-off-by: Nitesh Narayan Lal > > > > --- > > > > drivers/infiniband/hw/irdma/hw.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c > > > > index 7afb8a6a0526..7f13a051d4de 100644 > > > > --- a/drivers/infiniband/hw/irdma/hw.c > > > > +++ b/drivers/infiniband/hw/irdma/hw.c > > > > @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf, > > > > struct irdma_sc_dev *dev = &rf->sc_dev; > > > > > > > > dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx); > > > > - irq_set_affinity_hint(msix_vec->irq, NULL); > > > > + irq_update_affinity_hint(msix_vec->irq, NULL); > > > > free_irq(msix_vec->irq, dev_id); > > > > } > > > > > > > > @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq, > > > > } > > > > cpumask_clear(&msix_vec->mask); > > > > cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask); > > > > - irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask); > > > > + irq_set_affinity_and_hint(msix_vec->irq, &msix_vec->mask); > > > > > > I think that it needs to be irq_update_affinity_hint(). > > > > > > > Ah! I got a little confused from our last conversation about mlx5. > > > > IIUC mlx5 sub-function use case uses irdma (?) and that's why I thought > > that perhaps we would also want to define the affinity here from the beginning. > > mlx5 is connected to mlx5_ib/mlx5_vdpa e.t.c. > > Not sure about that, but I think that only mlx5 implements SIOV model. > > > > > In any case, I will make the change and re-post. > > Just FYI, I am hoping to collect more comments in the non-reviewed patches and address them in v4. Hence, I will wait for this week if I don't get anything I will just post another version by making the change in this driver. -- Thanks Nitesh