* Re: Build 0.6 version fail on musl libc [not found] ` <6528f839-274d-9d46-dea6-b20a90ac8cf8@kernel.dk> @ 2020-04-29 19:36 ` Jann Horn 2020-04-29 19:38 ` Jens Axboe 0 siblings, 1 reply; 2+ messages in thread From: Jann Horn @ 2020-04-29 19:36 UTC (permalink / raw) To: Jens Axboe; +Cc: Christoph Hellwig, Milan P. Stanić, io-uring, Linux API +linux-api On Wed, Apr 29, 2020 at 6:14 PM Jens Axboe <axboe@kernel.dk> wrote: > > On 4/29/20 9:29 AM, Jens Axboe wrote: > > On 4/29/20 9:26 AM, Christoph Hellwig wrote: > >> On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote: > >>> > >>> Not sure what the best fix is there, for 32-bit, your change will truncate > >>> the offset to 32-bit as off_t is only 4 bytes there. At least that's the > >>> case for me, maybe musl is different if it just has a nasty define for > >>> them. > >>> > >>> Maybe best to just make them uint64_t or something like that. > >> > >> The proper LFS type would be off64_t. > > > > Is it available anywhere? Because I don't have it. > > There seems to be better luck with __off64_t, but I don't even know > how widespread that is... Going to give it a go, we'll see. If you have questions about how to properly write UAPI headers, linux-api@ is probably a good place to ask. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Build 0.6 version fail on musl libc 2020-04-29 19:36 ` Build 0.6 version fail on musl libc Jann Horn @ 2020-04-29 19:38 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2020-04-29 19:38 UTC (permalink / raw) To: Jann Horn; +Cc: Christoph Hellwig, Milan P. Stanić, io-uring, Linux API On 4/29/20 1:36 PM, Jann Horn wrote: > +linux-api > > On Wed, Apr 29, 2020 at 6:14 PM Jens Axboe <axboe@kernel.dk> wrote: >> >> On 4/29/20 9:29 AM, Jens Axboe wrote: >>> On 4/29/20 9:26 AM, Christoph Hellwig wrote: >>>> On Wed, Apr 29, 2020 at 09:24:40AM -0600, Jens Axboe wrote: >>>>> >>>>> Not sure what the best fix is there, for 32-bit, your change will truncate >>>>> the offset to 32-bit as off_t is only 4 bytes there. At least that's the >>>>> case for me, maybe musl is different if it just has a nasty define for >>>>> them. >>>>> >>>>> Maybe best to just make them uint64_t or something like that. >>>> >>>> The proper LFS type would be off64_t. >>> >>> Is it available anywhere? Because I don't have it. >> >> There seems to be better luck with __off64_t, but I don't even know >> how widespread that is... Going to give it a go, we'll see. > > If you have questions about how to properly write UAPI headers, > linux-api@ is probably a good place to ask. This is in liburing, it's not the kernel side. The kernel side is fine. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-29 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200428192956.GA32615@arya.arvanta.net>
[not found] ` <04edfda7-0443-62e1-81af-30aa820cf256@kernel.dk>
[not found] ` <20200429152646.GA17156@infradead.org>
[not found] ` <e640dbcc-b25d-d305-ac97-a4724bd958e2@kernel.dk>
[not found] ` <6528f839-274d-9d46-dea6-b20a90ac8cf8@kernel.dk>
2020-04-29 19:36 ` Build 0.6 version fail on musl libc Jann Horn
2020-04-29 19:38 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).