From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0A1C4332F for ; Fri, 16 Dec 2022 17:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbiLPRFa (ORCPT ); Fri, 16 Dec 2022 12:05:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231646AbiLPRF1 (ORCPT ); Fri, 16 Dec 2022 12:05:27 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4A796C715 for ; Fri, 16 Dec 2022 09:05:25 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id k79so2189298pfd.7 for ; Fri, 16 Dec 2022 09:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d6OCT2ZdbDad/BMX0pnYZXGlc+e0Af4ihyKy0ZnG13g=; b=Z0kmH3yeP9Pw0NncQFCv47w2VUJEbyqW6wCtFqkqD35DzlnQjOymTL+UIizo91OQJV cb0kZr+GoPvoKk7VIQcBxGOOKum+LwY304gfBuOFvktTcQ6eucNVWmwasTR+x5mrxlVm gnkRdOPRq4ruRtwFXXARRsU13Njjzms5ldIpvk3E/COI4DMoiOu9FldaJbUDbM3KPhLC 3z+O/MQW6suHxTx+ukoHtZAEtChDXTCoe0OOSFcA/TvX6DhappkvNrejJMbPPrqlG0l0 fhUqJ93Dp6iPHkyFu5Fq51DzpAepYTiuFjdBpvyAIo6b/6LKeUxI04HggIUgvV/nzfNS Y8+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d6OCT2ZdbDad/BMX0pnYZXGlc+e0Af4ihyKy0ZnG13g=; b=xQLhzsEv++rWzXkmlQpPrJvF2bmeZ67pzBVj/NQxhQ1wA6vI3/JJIZ4W7hTbu7Eo2X jgyqVNux+xvDG5hqKYm58cHAuIotz/sjcrl7Tqf22PmBXyBeY9b+BojHpFPxS3fDhrCC cLl8FeEHxzC0I9dkVfwd0nCQG8cTkVhH854wLH2sjkaUmrPVKvkbS/cry1YA24Rjb0uB KHjsxrhtiDQB8Z8a+0bqF6zyLHjmsQdPlql5pBSJ/KwF09MxRIBGqral3MQsYOptTyOh kecXpd/NZq+DPre3zdnNcffiCJtiXReVIECNq1yh3hAX+o0zMRm92x9xdR2C/L8lXiqp Ymqw== X-Gm-Message-State: ANoB5pmwvUa+Xa2y6zS23TPrlOSieuXcKau9vYnuT1uc5/L00yfnr2Sb ame1edpM3mLpzpTnKw7/fNWYUMqQ5AROT1aiDXVY X-Google-Smtp-Source: AA0mqf456SOTI8h5405bjuHYKyboskc6RX/a1Ar+YL3tEroIPWZYM0tvvsDsxRnA/dxrNyn4bb9+vxyTCfLgcpe9goM= X-Received: by 2002:a63:64c5:0:b0:479:2109:506 with SMTP id y188-20020a6364c5000000b0047921090506mr1494989pgb.92.1671210325149; Fri, 16 Dec 2022 09:05:25 -0800 (PST) MIME-Version: 1.0 References: <45da8423b9b1e8fc7abd68cd2269acff8cf9022a.1670606054.git.rgb@redhat.com> <20221216164342.ojcbdifdmafq5njw@quack3> In-Reply-To: <20221216164342.ojcbdifdmafq5njw@quack3> From: Paul Moore Date: Fri, 16 Dec 2022 12:05:14 -0500 Message-ID: Subject: Re: [PATCH v5 2/3] fanotify: define struct members to hold response decision context To: Jan Kara Cc: Richard Guy Briggs , Linux-Audit Mailing List , LKML , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Eric Paris , Steve Grubb , Amir Goldstein Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, Dec 16, 2022 at 11:43 AM Jan Kara wrote: > > On Mon 12-12-22 09:06:10, Richard Guy Briggs wrote: > > This patch adds a flag, FAN_INFO and an extensible buffer to provide > > additional information about response decisions. The buffer contains > > one or more headers defining the information type and the length of the > > following information. The patch defines one additional information > > type, FAN_RESPONSE_INFO_AUDIT_RULE, to audit a rule number. This will > > allow for the creation of other information types in the future if other > > users of the API identify different needs. > > > > Suggested-by: Steve Grubb > > Link: https://lore.kernel.org/r/2745105.e9J7NaK4W3@x2 > > Suggested-by: Jan Kara > > Link: https://lore.kernel.org/r/20201001101219.GE17860@quack2.suse.cz > > Signed-off-by: Richard Guy Briggs > > Thanks for the patches. They look very good to me. Just two nits below. I > can do the small updates on commit if there would be no other changes. But > I'd like to get some review from audit guys for patch 3/3 before I commit > this. It's in my review queue, but it's a bit lower in the pile as my understanding is that the linux-next folks don't like to see new things in the next branches until after the merge window closes. -- paul-moore.com